[Clean-up] Fix MSAN and UBSAN issues found by clang-19#36707
Closed
veblush wants to merge 5 commits intogrpc:masterfrom
Closed
[Clean-up] Fix MSAN and UBSAN issues found by clang-19#36707veblush wants to merge 5 commits intogrpc:masterfrom
veblush wants to merge 5 commits intogrpc:masterfrom
Conversation
yashykt
reviewed
May 23, 2024
| // | ||
|
|
||
| static void fork_fd_list_remove_node(grpc_fork_fd_list* node) { | ||
| gpr_mu_lock(&fork_fd_list_mu); |
Member
There was a problem hiding this comment.
this seems like a change in logic
Contributor
Author
There was a problem hiding this comment.
Not really. fork_fd_list_remove_grpc_fd is a new replacement for the old fork_fd_list_remove_node and all call sites for fork_fd_list_remove_node are updated to use fork_fd_list_remove_grpc_fd
Member
Contributor
There was a problem hiding this comment.
I believe
if (track_fds_for_fork) {
might be needed so there's no overhead if fork support is not necessary
Contributor
Author
There was a problem hiding this comment.
^ fork_fd_list_remove_grpc_fd does. No one calls fork_fd_list_remove_node other than fork_fd_list_remove_grpc_fd
yashykt
approved these changes
May 23, 2024
paulosjca
pushed a commit
to paulosjca/grpc
that referenced
this pull request
May 23, 2024
Fixed various MSAN and UBSAN issues found in an attempt to bump the clang version used for RBE. (grpc#36685) As our xSAN tests are using RBE, it revealed a few new issues. This PR is to fix all of those. Closes grpc#36707 COPYBARA_INTEGRATE_REVIEW=grpc#36707 from veblush:fix-xsan ebbebc2 PiperOrigin-RevId: 636685138
jdcormie
pushed a commit
to jdcormie/grpc
that referenced
this pull request
May 24, 2024
Fixed various MSAN and UBSAN issues found in an attempt to bump the clang version used for RBE. (grpc#36685) As our xSAN tests are using RBE, it revealed a few new issues. This PR is to fix all of those. Closes grpc#36707 COPYBARA_INTEGRATE_REVIEW=grpc#36707 from veblush:fix-xsan ebbebc2 PiperOrigin-RevId: 636685138
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed various MSAN and UBSAN issues found in an attempt to bump the clang version used for RBE. (#36685) As our xSAN tests are using RBE, it revealed a few new issues. This PR is to fix all of those.