[grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log#36678
Closed
tanvi-jagtap wants to merge 24 commits intogrpc:masterfrom
Closed
[grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log#36678tanvi-jagtap wants to merge 24 commits intogrpc:masterfrom
tanvi-jagtap wants to merge 24 commits intogrpc:masterfrom
Conversation
sastryvp
approved these changes
May 22, 2024
paulosjca
pushed a commit
to paulosjca/grpc
that referenced
this pull request
May 23, 2024
…log (grpc#36678) [grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log In this CL we are migrating from gRPCs own gpr logging mechanism to absl logging mechanism. The intention is to deprecate gpr_log in the future. We have the following mapping 1. gpr_log(GPR_INFO,...) -> LOG(INFO) 2. gpr_log(GPR_ERROR,...) -> LOG(ERROR) 3. gpr_log(GPR_DEBUG,...) -> VLOG(2) Reviewers need to check : 1. If the above mapping is correct. 2. The content of the log is as before. gpr_log format strings did not use string_view or std::string . absl LOG accepts these. So there will be some elimination of string_view and std::string related conversions. This is expected. Closes grpc#36678 COPYBARA_INTEGRATE_REVIEW=grpc#36678 from tanvi-jagtap:test_cpp_gpr_log 81b8f41 PiperOrigin-RevId: 636410944
jdcormie
pushed a commit
to jdcormie/grpc
that referenced
this pull request
May 24, 2024
…log (grpc#36678) [grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log In this CL we are migrating from gRPCs own gpr logging mechanism to absl logging mechanism. The intention is to deprecate gpr_log in the future. We have the following mapping 1. gpr_log(GPR_INFO,...) -> LOG(INFO) 2. gpr_log(GPR_ERROR,...) -> LOG(ERROR) 3. gpr_log(GPR_DEBUG,...) -> VLOG(2) Reviewers need to check : 1. If the above mapping is correct. 2. The content of the log is as before. gpr_log format strings did not use string_view or std::string . absl LOG accepts these. So there will be some elimination of string_view and std::string related conversions. This is expected. Closes grpc#36678 COPYBARA_INTEGRATE_REVIEW=grpc#36678 from tanvi-jagtap:test_cpp_gpr_log 81b8f41 PiperOrigin-RevId: 636410944
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log
In this CL we are migrating from gRPCs own gpr logging mechanism to absl logging mechanism. The intention is to deprecate gpr_log in the future.
We have the following mapping
Reviewers need to check :
gpr_log format strings did not use string_view or std::string . absl LOG accepts these. So there will be some elimination of string_view and std::string related conversions. This is expected.