Skip to content

[backport][iomgr][EventEngine] Improve server handling of file descri…#36489

Merged
veblush merged 1 commit intogrpc:v1.46.xfrom
drfloob:backport/1.46/33656
Apr 30, 2024
Merged

[backport][iomgr][EventEngine] Improve server handling of file descri…#36489
veblush merged 1 commit intogrpc:v1.46.xfrom
drfloob:backport/1.46/33656

Conversation

@drfloob
Copy link
Copy Markdown
Member

@drfloob drfloob commented Apr 30, 2024

…ptor exhaustion (#33656)

@drfloob
Copy link
Copy Markdown
Member Author

drfloob commented Apr 30, 2024

The CI is broken for 1.46.x. @apolcyn can you take a look when you get a chance?

This PR builds file inside a docker container with the right toolchain.

docker run -it --rm gcr.io/oss-fuzz-base/base-builder@sha256:5eceb81f57599d63ca7c9a70c8968b23b128119699626ca749017019eb0b523f /bin/bash

# inside the container
git clone https://github.com/drfloob/grpc
git checkout git checkout backport/1.46/33656
git submodule update --init
bazel build //test/cpp/server:server_builder_test //test/cpp/server:server_builder_test //test/cpp/microbenchmarks/... //test/core/transport/binder/end2end:binder_server_test@poller=epoll1 :all //test/cpp/microbenchmarks:all grpc++ grpc++_unsecure //test/cpp/... grpc++_xds_server test/core/transport/binder/... test/cpp/server/...

@drfloob drfloob requested a review from veblush April 30, 2024 21:20
@veblush
Copy link
Copy Markdown
Contributor

veblush commented Apr 30, 2024

@apolcyn It's your call how and when to release gRPC C# with this fix.

@drfloob drfloob marked this pull request as ready for review April 30, 2024 21:29
@veblush veblush merged commit 1d85b01 into grpc:v1.46.x Apr 30, 2024
@drfloob
Copy link
Copy Markdown
Member Author

drfloob commented Apr 30, 2024

Note: partially satisfies #36474

ganesh-tn pushed a commit to ganesh-tn/grpc that referenced this pull request Oct 3, 2025
@Mingli-001
Copy link
Copy Markdown

Hi @drfloob,
What do you mean "partially satisfies #36474"? Could you help to guide if the CVE-2023-4785 issue fixed after #36489 is merged in grpc 1.46.x?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants