Back-end for new core API#357
Conversation
Simplifies locking and cross request chatter significantly
Conflicts: test/core/echo/client.c
Reduce duplication of handling in many places and simplify internally tracked state.
|
I've pushed some simplifications for this code. It seems to have unsquashed things in my moves between machines, so apologies for the very log commit list. |
There was a problem hiding this comment.
There is not description there.
There was a problem hiding this comment.
I just pushed some documentation on this data structure - it got lost at some point.
src/core/surface/call.c
Outdated
There was a problem hiding this comment.
The comments seem to match my understanding but this last paragraph is not quite clear to me. Maybe it will get better when I finish reading code. Is "set" == "group"? Should masters[op] be masters[set] to make it more clear? If there is at most one op of a kind active at once, why not just make masters indexed by op instead of by request_set[op]? Also there is "a the".
There was a problem hiding this comment.
Just pushed some cleanup -- clearer?
|
LGTM |
This is the backend for the new core batch-based API.
It's missing an implementation of the surface layer API, and the tests that would be required to add that.
I'll fill them in with a future pull request (or add them to this one depending on whether code review or actual coding has higher latency.