[ruby] [v1.61.x] Build/test ruby 3.3 and build native gems with Ruby 3.3 support#35594
Closed
chadlwilson wants to merge 1 commit intogrpc:v1.61.xfrom
Closed
[ruby] [v1.61.x] Build/test ruby 3.3 and build native gems with Ruby 3.3 support#35594chadlwilson wants to merge 1 commit intogrpc:v1.61.xfrom
chadlwilson wants to merge 1 commit intogrpc:v1.61.xfrom
Conversation
grpc#35399) Updates ruby-compiler-dock to 1.4.0 which brings Ruby 3.3 final support per https://github.com/rake-compiler/rake-compiler-dock/releases/tag/1.4.0 and starts cross-compiling for ruby 3.3. I can't find obviously where the test infrastructure configuration is to run the tests under Ruby 3.3, so might need pointers or an accompanying PR for the test infra. (I note grpc#31991 from @apolcyn so perhaps currently they are not run against newer versions) Fixes grpc#35396 - Backport to `1.60` is desirable since currently the Ruby gems cannot be installed with Ruby 3.3 and have to be built from source. Closes grpc#35399 PiperOrigin-RevId: 599200628 (cherry picked from commit 43d2b28)
Contributor
Author
|
Done in #35614 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #35399 for
1.61since release branch appears to have been cut for pre-release builds.It'd be good to land this for
1.61since Ruby 3.3 has been out for a few weeks and this is one of the most popular native gems which is blocking some testing/upgrades by users who can't/don't want to build from source.I read
CONTRIBUTING.mdbut not entirely sure if this is needed, or whether the team have a habit of merging from master selectively prior to release. Let me know if this PR is unnecessary for consideration for1.61release.Updates ruby-compiler-dock to 1.4.0 which brings Ruby 3.3 final support per https://github.com/rake-compiler/rake-compiler-dock/releases/tag/1.4.0 and starts cross-compiling for ruby 3.3.
As noted in #31991 and #35399 (comment) the tests currently don't run on all ruby versions, so this is still an existing gap which this PR does not close, but also doesn't appear to make worse.
FYI @alto-ruby @apolcyn