[ruby] Build/test ruby 3.3 and build native gems with Ruby 3.3 support by chadlwilson · Pull Request #35399 · grpc/grpc

chadlwilson · 2023-12-28T03:32:53Z

Updates ruby-compiler-dock to 1.4.0 which brings Ruby 3.3 final support per https://github.com/rake-compiler/rake-compiler-dock/releases/tag/1.4.0 and starts cross-compiling for ruby 3.3.

I can't find obviously where the test infrastructure configuration is to run the tests under Ruby 3.3, so might need pointers or an accompanying PR for the test infra. (I note #31991 from @apolcyn so perhaps currently they are not run against newer versions)

Fixes #35396

Backport to 1.60 is desirable since currently the Ruby gems cannot be installed with Ruby 3.3 and have to be built from source.

linux-foundation-easycla · 2023-12-28T03:32:57Z

The committers listed above are authorized under a signed CLA.

✅ login: chadlwilson / name: Chad Wilson (904aea5)
✅ login: apolcyn (5c14303)

chadlwilson · 2024-01-03T04:45:49Z

Thx for kicking off the build @alto-ruby .

Sanity tests are failing due to not locking the docker image versions for rake-compiler-dock testing images but I think this is a chicken vs egg problem that an external contributor possibly can't solve. Perhaps needs a Googler to do something like the following?

tools/dockerfile/push_testing_images.sh
update the values within the current_version files.

re-run generate_dockerimage_current_versions_bzl.sh and commit changes to dockerimage_current_versions.bzl.

grpc/tools/bazelify_tests/dockerimage_current_versions.bzl

Lines 22 to 29 in 2d7b751

    
           "third_party/rake-compiler-dock/rake_aarch64-linux.current_version": "docker://us-docker.pkg.dev/grpc-testing/testing-images-public/rake_aarch64-linux@sha256:a015b83950b891a61b43cbfcdac5bcdfd62d34ac58652302b3e25633274e942a", 
        
           "third_party/rake-compiler-dock/rake_arm64-darwin.current_version": "docker://us-docker.pkg.dev/grpc-testing/testing-images-public/rake_arm64-darwin@sha256:5e207456cc0cdd67f308023b5cbc6932a6db56e58a537862292e76c8ac2e5f90", 
        
           "third_party/rake-compiler-dock/rake_x64-mingw-ucrt.current_version": "docker://us-docker.pkg.dev/grpc-testing/testing-images-public/rake_x64-mingw-ucrt@sha256:4b60f82c8425db2b8fb430833175538aa362cf61d7f88c9c68cbf5970bf8b92c", 
        
           "third_party/rake-compiler-dock/rake_x64-mingw32.current_version": "docker://us-docker.pkg.dev/grpc-testing/testing-images-public/rake_x64-mingw32@sha256:eab102dc22d88124c78444f35b3a24bb45bce379b147cca0c5b64662ca41a82c", 
        
           "third_party/rake-compiler-dock/rake_x86-linux.current_version": "docker://us-docker.pkg.dev/grpc-testing/testing-images-public/rake_x86-linux@sha256:c1221bb41bb36ecc2b998431aabdffacec8bacea03dde2c6bf717a71a25975e2", 
        
           "third_party/rake-compiler-dock/rake_x86-mingw32.current_version": "docker://us-docker.pkg.dev/grpc-testing/testing-images-public/rake_x86-mingw32@sha256:909ae31711de69a129bac3b2ed568ccc771f467ec3c712cf2cb142c3cdd6a154", 
        
           "third_party/rake-compiler-dock/rake_x86_64-darwin.current_version": "docker://us-docker.pkg.dev/grpc-testing/testing-images-public/rake_x86_64-darwin@sha256:44865f928d61f97369903673785fcbe0f6a823a60efcd045c025ca9c5579bcee", 
        
           "third_party/rake-compiler-dock/rake_x86_64-linux.current_version": "docker://us-docker.pkg.dev/grpc-testing/testing-images-public/rake_x86_64-linux@sha256:91603592860c33da1773711b9422b7ffc8ecb69892d112082be17093f2995095",

The other test failures I couldn't see the correlation with the changes but rebased anyway, in case it's something fixed on master.

alto-ruby · 2024-01-04T16:09:35Z

@apolcyn for pushing new docker images

apolcyn

looks generally right - requested just a couple minor changes

Regarding testing

yes we ought to get in that PR you referenced. I'll be in office next week and can look at that.
we should create a "distribtest" for ruby 3.3 by adding an entry for it in

grpc/tools/run_tests/artifacts/distribtest_targets.py

Line 481 in 850912a

RubyDistribTest("linux", "x64", "ubuntu2204", presubmit=True),

, it will need a new docker image like this one. @alto-ruby do you have time to follow up on that?

(I'm out of the office right now but will be back next week, if the review needs more time).

Also I have pushed docker images and sent you a patch on this branch: chadlwilson#1

tools/internal_ci/helper_scripts/prepare_build_macos_rc

src/ruby/nativedebug/README.md

Updates ruby-compiler-dock to 1.4.0 which brings Ruby 3.3 final support per https://github.com/rake-compiler/rake-compiler-dock/releases/tag/1.4.0 Signed-off-by: Chad Wilson <chadw@thoughtworks.com>

chadlwilson · 2024-01-11T02:37:39Z

I've merged your changes, made the requested tweaks and rebased off master. Will need some help to kick off the build/test again (or point me to them) as now I can't see the build runs linked to the PR after the force pushes so not quite sure what the current pass/fail state is.

yes we ought to get in that PR you referenced. I'll be in office next week and can look at that.

we should create a "distribtest" for ruby 3.3 by adding an entry for it in

grpc/tools/run_tests/artifacts/distribtest_targets.py

Line 481 in 850912a

RubyDistribTest("linux", "x64", "ubuntu2204", presubmit=True),

OK, will go with your and @alto-ruby guidance on whether that's a pre-requisite for this or something we can do subsequently.

apolcyn · 2024-01-11T02:43:17Z

I've kicked off tests

OK, will go with your and @alto-ruby guidance on whether that's a pre-requisite for this or something we can do subsequently.

Sounds good. I'm fine with the test changes to go in a subsequent PR. But still cc @alto-ruby for help on this aspect.

chadlwilson · 2024-01-11T03:56:38Z

Can someone point me to the appropriate build/test run invocation on source.cloud.google.com? Kokoro doesn't seem to be updating this PR with the status checks and I can't seem to navigate as an external contributor to find the latest PR runs.

chadlwilson · 2024-01-12T02:03:45Z

Looks like everything is passing so that's a good sign 👍

chadlwilson · 2024-01-15T15:26:37Z

@alto-ruby @apolcyn ~~Anything else that needs to be done here? Do I need to change the base to v1.61.x?~~

Edit: no problem, forgot about copybara flow.

@apolcyn

grpc#35399) Updates ruby-compiler-dock to 1.4.0 which brings Ruby 3.3 final support per https://github.com/rake-compiler/rake-compiler-dock/releases/tag/1.4.0 and starts cross-compiling for ruby 3.3. I can't find obviously where the test infrastructure configuration is to run the tests under Ruby 3.3, so might need pointers or an accompanying PR for the test infra. (I note grpc#31991 from @apolcyn so perhaps currently they are not run against newer versions) Fixes grpc#35396 - Backport to `1.60` is desirable since currently the Ruby gems cannot be installed with Ruby 3.3 and have to be built from source. Closes grpc#35399 PiperOrigin-RevId: 599200628 (cherry picked from commit 43d2b28)

@apolcyn

grpc#35399) Updates ruby-compiler-dock to 1.4.0 which brings Ruby 3.3 final support per https://github.com/rake-compiler/rake-compiler-dock/releases/tag/1.4.0 and starts cross-compiling for ruby 3.3. I can't find obviously where the test infrastructure configuration is to run the tests under Ruby 3.3, so might need pointers or an accompanying PR for the test infra. (I note grpc#31991 from @apolcyn so perhaps currently they are not run against newer versions) Fixes grpc#35396 - Backport to `1.60` is desirable since currently the Ruby gems cannot be installed with Ruby 3.3 and have to be built from source. Closes grpc#35399 PiperOrigin-RevId: 599200628

@apolcyn

…3.3 support (#35399)" (#35614) Updates ruby-compiler-dock to 1.4.0 which brings Ruby 3.3 final support per https://github.com/rake-compiler/rake-compiler-dock/releases/tag/1.4.0 and starts cross-compiling for ruby 3.3. I can't find obviously where the test infrastructure configuration is to run the tests under Ruby 3.3, so might need pointers or an accompanying PR for the test infra. (I note #31991 from @apolcyn so perhaps currently they are not run against newer versions) Fixes #35396 - Backport to `1.60` is desirable since currently the Ruby gems cannot be installed with Ruby 3.3 and have to be built from source. Closes #35399 PiperOrigin-RevId: 599200628  Co-authored-by: Chad Wilson <chadw@thoughtworks.com>

As title Partial followup to #35399 Closes #35788 PiperOrigin-RevId: 603786425

@apolcyn

#38338) Updates ruby-compiler-dock to `1.7.1` to [bring Ruby 3.4 support](https://github.com/rake-compiler/rake-compiler-dock/releases/tag/v1.7.0) and starts cross-compiling native gems for Ruby 3.4. Added a distribtest as well. I believe from last year at #35399 that this probably requires @apolcyn or another Googler to build+push+update the `grpc-testing` images, along with - `tools/dockerfile/push_testing_images.sh` - update the values within [the current_version files](https://github.com/grpc/grpc/tree/9b77138b71e04bb127ec1fb3ae280bca33c59ae1/third_party/rake-compiler-dock). re-run generate_dockerimage_current_versions_bzl.sh and commit changes to dockerimage_current_versions.bzl. - similar for the `ruby_debian11_x64_ruby_3_4` image added here (needs to be built and pushed) Marking as draft until we are happy with approach. Note that fully pre-compiled install wont be possible until protobuf pushes their own 3.4 native versions via protocolbuffers/protobuf#19752 (and a release), but this does not seem to block things as protobuf compile seems to be working OK without code change right now. Closes #38338 PiperOrigin-RevId: 715431412

@apolcyn

grpc#38338) Updates ruby-compiler-dock to `1.7.1` to [bring Ruby 3.4 support](https://github.com/rake-compiler/rake-compiler-dock/releases/tag/v1.7.0) and starts cross-compiling native gems for Ruby 3.4. Added a distribtest as well. I believe from last year at grpc#35399 that this probably requires @apolcyn or another Googler to build+push+update the `grpc-testing` images, along with - `tools/dockerfile/push_testing_images.sh` - update the values within [the current_version files](https://github.com/grpc/grpc/tree/9b77138b71e04bb127ec1fb3ae280bca33c59ae1/third_party/rake-compiler-dock). re-run generate_dockerimage_current_versions_bzl.sh and commit changes to dockerimage_current_versions.bzl. - similar for the `ruby_debian11_x64_ruby_3_4` image added here (needs to be built and pushed) Marking as draft until we are happy with approach. Note that fully pre-compiled install wont be possible until protobuf pushes their own 3.4 native versions via protocolbuffers/protobuf#19752 (and a release), but this does not seem to block things as protobuf compile seems to be working OK without code change right now. Closes grpc#38338 PiperOrigin-RevId: 715431412 (cherry picked from commit 18bebd3)

@apolcyn

grpc#38338) Updates ruby-compiler-dock to `1.7.1` to [bring Ruby 3.4 support](https://github.com/rake-compiler/rake-compiler-dock/releases/tag/v1.7.0) and starts cross-compiling native gems for Ruby 3.4. Added a distribtest as well. I believe from last year at grpc#35399 that this probably requires @apolcyn or another Googler to build+push+update the `grpc-testing` images, along with - `tools/dockerfile/push_testing_images.sh` - update the values within [the current_version files](https://github.com/grpc/grpc/tree/9b77138b71e04bb127ec1fb3ae280bca33c59ae1/third_party/rake-compiler-dock). re-run generate_dockerimage_current_versions_bzl.sh and commit changes to dockerimage_current_versions.bzl. - similar for the `ruby_debian11_x64_ruby_3_4` image added here (needs to be built and pushed) Marking as draft until we are happy with approach. Note that fully pre-compiled install wont be possible until protobuf pushes their own 3.4 native versions via protocolbuffers/protobuf#19752 (and a release), but this does not seem to block things as protobuf compile seems to be working OK without code change right now. Closes grpc#38338 PiperOrigin-RevId: 715431412

@apolcyn

grpc#38338) Updates ruby-compiler-dock to `1.7.1` to [bring Ruby 3.4 support](https://github.com/rake-compiler/rake-compiler-dock/releases/tag/v1.7.0) and starts cross-compiling native gems for Ruby 3.4. Added a distribtest as well. I believe from last year at grpc#35399 that this probably requires @apolcyn or another Googler to build+push+update the `grpc-testing` images, along with - `tools/dockerfile/push_testing_images.sh` - update the values within [the current_version files](https://github.com/grpc/grpc/tree/9b77138b71e04bb127ec1fb3ae280bca33c59ae1/third_party/rake-compiler-dock). re-run generate_dockerimage_current_versions_bzl.sh and commit changes to dockerimage_current_versions.bzl. - similar for the `ruby_debian11_x64_ruby_3_4` image added here (needs to be built and pushed) Marking as draft until we are happy with approach. Note that fully pre-compiled install wont be possible until protobuf pushes their own 3.4 native versions via protocolbuffers/protobuf#19752 (and a release), but this does not seem to block things as protobuf compile seems to be working OK without code change right now. Closes grpc#38338 PiperOrigin-RevId: 715431412

github-actions bot added the lang/ruby label Dec 28, 2023

chadlwilson force-pushed the ruby-3.3-support branch from 3dda32b to 447de3a Compare December 28, 2023 03:49

chadlwilson changed the title ~~[ruby] Build native gems with Ruby 3.3 support~~ [ruby] Build/test ruby 3.3 and build native gems with Ruby 3.3 support Dec 28, 2023

chadlwilson mentioned this pull request Dec 28, 2023

[Ruby] Update required_ruby_version from Ruby 2.5 to Ruby 2.6 #31132

Open

alto-ruby added the kokoro:run label Jan 1, 2024

alto-ruby requested a review from apolcyn January 1, 2024 19:33

grpc-kokoro removed the kokoro:run label Jan 1, 2024

grpc-checks bot added per-call-memory/decrease per-channel-memory/neutral bloat/none labels Jan 1, 2024

chadlwilson force-pushed the ruby-3.3-support branch from 447de3a to 2de4404 Compare January 3, 2024 04:15

alto-ruby mentioned this pull request Jan 4, 2024

Ruby gem 1.57.0 fails to install in Windows with Ruby 3.0.6 #34168

Open

chadlwilson mentioned this pull request Jan 7, 2024

chore: update trigger-protobuf.cfg to add ruby 3.3 for protobuf googleapis/ruby-common-tools#286

Closed

chadlwilson force-pushed the ruby-3.3-support branch from 2de4404 to 7db5e73 Compare January 8, 2024 02:49

apolcyn mentioned this pull request Jan 10, 2024

updates after pushing docker images chadlwilson/grpc#1

Merged

apolcyn reviewed Jan 10, 2024

View reviewed changes

tools/internal_ci/helper_scripts/prepare_build_macos_rc Show resolved Hide resolved

src/ruby/nativedebug/README.md Show resolved Hide resolved

chadlwilson and others added 2 commits January 11, 2024 10:15

[ruby] Build/test ruby 3.3 and build native gems with Ruby 3.3 support

904aea5

Updates ruby-compiler-dock to 1.4.0 which brings Ruby 3.3 final support per https://github.com/rake-compiler/rake-compiler-dock/releases/tag/1.4.0 Signed-off-by: Chad Wilson <chadw@thoughtworks.com>

updates after pushing docker images

5c14303

chadlwilson force-pushed the ruby-3.3-support branch from 195227d to 5c14303 Compare January 11, 2024 02:19

apolcyn added the release notes: yes Indicates if PR needs to be in release notes label Jan 11, 2024

alto-ruby added the kokoro:run label Jan 11, 2024

grpc-kokoro removed the kokoro:run label Jan 11, 2024

apolcyn approved these changes Jan 17, 2024

View reviewed changes

wildmaples approved these changes Jan 17, 2024

View reviewed changes

copybara-service bot closed this in 43d2b28 Jan 17, 2024

splittingred mentioned this pull request Jan 17, 2024

Add ruby 3.3 support, drop Ruby 2.x support bigcommerce/gruf#199

Merged

chadlwilson deleted the ruby-3.3-support branch January 18, 2024 01:55

chadlwilson mentioned this pull request Jan 18, 2024

[ruby] [v1.61.x] Build/test ruby 3.3 and build native gems with Ruby 3.3 support #35594

Closed

apolcyn mentioned this pull request Jan 19, 2024

[ruby] backport "Build/test ruby 3.3 and build native gems with Ruby 3.3 support (#35399)" #35614

Merged

apolcyn mentioned this pull request Feb 1, 2024

[ruby] add distrib tests for ruby 3.1-3.3 #35788

Closed

copybara-service bot pushed a commit that referenced this pull request Feb 2, 2024

[ruby] add distrib tests for ruby 3.1-3.3 (#35788)

f82ecf4

As title Partial followup to #35399 Closes #35788 PiperOrigin-RevId: 603786425

chadlwilson mentioned this pull request Dec 25, 2024

[ruby] Build/test ruby 3.4 and build native gems with Ruby 3.4 support #38338

Closed

chadlwilson mentioned this pull request Jan 22, 2026

[Ruby] Build/test ruby 4.0 and build native gems with Ruby 4.0 support #41324

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ruby] Build/test ruby 3.3 and build native gems with Ruby 3.3 support#35399

[ruby] Build/test ruby 3.3 and build native gems with Ruby 3.3 support#35399
chadlwilson wants to merge 2 commits intogrpc:masterfrom
chadlwilson:ruby-3.3-support

chadlwilson commented Dec 28, 2023 •

edited

Loading

Uh oh!

linux-foundation-easycla bot commented Dec 28, 2023 •

edited

Loading

Uh oh!

chadlwilson commented Jan 3, 2024

Uh oh!

alto-ruby commented Jan 4, 2024

Uh oh!

apolcyn left a comment

Uh oh!

Uh oh!

Uh oh!

chadlwilson commented Jan 11, 2024 •

edited

Loading

Uh oh!

apolcyn commented Jan 11, 2024

Uh oh!

chadlwilson commented Jan 11, 2024

Uh oh!

chadlwilson commented Jan 12, 2024

Uh oh!

chadlwilson commented Jan 15, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

chadlwilson commented Dec 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linux-foundation-easycla bot commented Dec 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chadlwilson commented Jan 3, 2024

Uh oh!

alto-ruby commented Jan 4, 2024

Uh oh!

apolcyn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

chadlwilson commented Jan 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

apolcyn commented Jan 11, 2024

Uh oh!

chadlwilson commented Jan 11, 2024

Uh oh!

chadlwilson commented Jan 12, 2024

Uh oh!

chadlwilson commented Jan 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

chadlwilson commented Dec 28, 2023 •

edited

Loading

linux-foundation-easycla bot commented Dec 28, 2023 •

edited

Loading

chadlwilson commented Jan 11, 2024 •

edited

Loading

chadlwilson commented Jan 15, 2024 •

edited

Loading