[Python Observability] Allow create call with registered method#35002
Closed
XuanWang-Amos wants to merge 25 commits intogrpc:masterfrom
Closed
[Python Observability] Allow create call with registered method#35002XuanWang-Amos wants to merge 25 commits intogrpc:masterfrom
XuanWang-Amos wants to merge 25 commits intogrpc:masterfrom
Conversation
gnossen
reviewed
Nov 17, 2023
copybara-service bot
pushed a commit
that referenced
this pull request
Nov 20, 2023
Based on [OpenTelemetry Metrics gRFC](https://github.com/grpc/proposal/blob/master/A66-otel-stats.md#opentelemetry-metrics), we should recored unregistered RPC method name as `other`, this PR adds the ability to pass register method information when creating a call. We'll consider calls created using generated stubs as registered, note that this won't prevent user from setting `registered_method=True` when creating calls manually. This is also enabled for simple stub flow but **NOT enabled for AsyncIO**, we'll add that later when start working on AsyncIO Observability. Note: * **Distribution Tests Python Windows** test failed with error `AttributeError: module 'setuptools.errors' has no attribute 'CompileError'`, it's because we're using low version of setuptools for windows 3.7. I don't think the underlay issue is related to this PR, I tried debug it in this run but it passed: https://fusion2.corp.google.com/invocations/565f0f90-5965-40ca-b6b6-dc7ddc24e46a <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> Closes #35002 FUTURE_COPYBARA_INTEGRATE_REVIEW=#35002 from XuanWang-Amos:add_registered_method 45a68b1 PiperOrigin-RevId: 584141205
gnossen
reviewed
Nov 20, 2023
copybara-service bot
pushed a commit
that referenced
this pull request
Nov 20, 2023
Based on [OpenTelemetry Metrics gRFC](https://github.com/grpc/proposal/blob/master/A66-otel-stats.md#opentelemetry-metrics), we should recored unregistered RPC method name as `other`, this PR adds the ability to pass register method information when creating a call. We'll consider calls created using generated stubs as registered, note that this won't prevent user from setting `registered_method=True` when creating calls manually. This is also enabled for simple stub flow but **NOT enabled for AsyncIO**, we'll add that later when start working on AsyncIO Observability. Note: * **Distribution Tests Python Windows** test failed with error `AttributeError: module 'setuptools.errors' has no attribute 'CompileError'`, it's because we're using low version of setuptools for windows 3.7. I don't think the underlay issue is related to this PR, I tried debug it in this run but it passed: https://fusion2.corp.google.com/invocations/565f0f90-5965-40ca-b6b6-dc7ddc24e46a <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> Closes #35002 FUTURE_COPYBARA_INTEGRATE_REVIEW=#35002 from XuanWang-Amos:add_registered_method 45a68b1 PiperOrigin-RevId: 584141205
copybara-service bot
pushed a commit
that referenced
this pull request
Nov 21, 2023
Based on [OpenTelemetry Metrics gRFC](https://github.com/grpc/proposal/blob/master/A66-otel-stats.md#opentelemetry-metrics), we should recored unregistered RPC method name as `other`, this PR adds the ability to pass register method information when creating a call. We'll consider calls created using generated stubs as registered, note that this won't prevent user from setting `registered_method=True` when creating calls manually. This is also enabled for simple stub flow but **NOT enabled for AsyncIO**, we'll add that later when start working on AsyncIO Observability. Note: * **Distribution Tests Python Windows** test failed with error `AttributeError: module 'setuptools.errors' has no attribute 'CompileError'`, it's because we're using low version of setuptools for windows 3.7. I don't think the underlay issue is related to this PR, I tried debug it in this run but it passed: https://fusion2.corp.google.com/invocations/565f0f90-5965-40ca-b6b6-dc7ddc24e46a <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> Closes #35002 FUTURE_COPYBARA_INTEGRATE_REVIEW=#35002 from XuanWang-Amos:add_registered_method 45a68b1 PiperOrigin-RevId: 584141205
copybara-service bot
pushed a commit
that referenced
this pull request
Nov 21, 2023
Based on [OpenTelemetry Metrics gRFC](https://github.com/grpc/proposal/blob/master/A66-otel-stats.md#opentelemetry-metrics), we should recored unregistered RPC method name as `other`, this PR adds the ability to pass register method information when creating a call. We'll consider calls created using generated stubs as registered, note that this won't prevent user from setting `registered_method=True` when creating calls manually. This is also enabled for simple stub flow but **NOT enabled for AsyncIO**, we'll add that later when start working on AsyncIO Observability. Note: * **Distribution Tests Python Windows** test failed with error `AttributeError: module 'setuptools.errors' has no attribute 'CompileError'`, it's because we're using low version of setuptools for windows 3.7. I don't think the underlay issue is related to this PR, I tried debug it in this run but it passed: https://fusion2.corp.google.com/invocations/565f0f90-5965-40ca-b6b6-dc7ddc24e46a <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> Closes #35002 FUTURE_COPYBARA_INTEGRATE_REVIEW=#35002 from XuanWang-Amos:add_registered_method 45a68b1 PiperOrigin-RevId: 584141205
copybara-service bot
pushed a commit
that referenced
this pull request
Nov 21, 2023
Based on [OpenTelemetry Metrics gRFC](https://github.com/grpc/proposal/blob/master/A66-otel-stats.md#opentelemetry-metrics), we should recored unregistered RPC method name as `other`, this PR adds the ability to pass register method information when creating a call. We'll consider calls created using generated stubs as registered, note that this won't prevent user from setting `registered_method=True` when creating calls manually. This is also enabled for simple stub flow but **NOT enabled for AsyncIO**, we'll add that later when start working on AsyncIO Observability. Note: * **Distribution Tests Python Windows** test failed with error `AttributeError: module 'setuptools.errors' has no attribute 'CompileError'`, it's because we're using low version of setuptools for windows 3.7. I don't think the underlay issue is related to this PR, I tried debug it in this run but it passed: https://fusion2.corp.google.com/invocations/565f0f90-5965-40ca-b6b6-dc7ddc24e46a <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> Closes #35002 FUTURE_COPYBARA_INTEGRATE_REVIEW=#35002 from XuanWang-Amos:add_registered_method 45a68b1 PiperOrigin-RevId: 584141205
copybara-service bot
pushed a commit
that referenced
this pull request
Nov 21, 2023
Based on [OpenTelemetry Metrics gRFC](https://github.com/grpc/proposal/blob/master/A66-otel-stats.md#opentelemetry-metrics), we should recored unregistered RPC method name as `other`, this PR adds the ability to pass register method information when creating a call. We'll consider calls created using generated stubs as registered, note that this won't prevent user from setting `registered_method=True` when creating calls manually. This is also enabled for simple stub flow but **NOT enabled for AsyncIO**, we'll add that later when start working on AsyncIO Observability. Note: * **Distribution Tests Python Windows** test failed with error `AttributeError: module 'setuptools.errors' has no attribute 'CompileError'`, it's because we're using low version of setuptools for windows 3.7. I don't think the underlay issue is related to this PR, I tried debug it in this run but it passed: https://fusion2.corp.google.com/invocations/565f0f90-5965-40ca-b6b6-dc7ddc24e46a <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> Closes #35002 FUTURE_COPYBARA_INTEGRATE_REVIEW=#35002 from XuanWang-Amos:add_registered_method 45a68b1 PiperOrigin-RevId: 584141205
816fcf5 to
963e8a7
Compare
XuanWang-Amos
added a commit
to XuanWang-Amos/grpc
that referenced
this pull request
Jan 11, 2024
…od (grpc#35002)" This reverts commit 9a7c0b5.
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 11, 2024
We're having some issues internally, rolling this change back for now and wait for the affected users to figure out a solution. This reverts: #35002, #35482 and 6872a7a <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> Closes #35522 PiperOrigin-RevId: 597671989
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on OpenTelemetry Metrics gRFC, we should recored unregistered RPC method name as
other, this PR adds the ability to pass register method information when creating a call.We'll consider calls created using generated stubs as registered, note that this won't prevent user from setting
registered_method=Truewhen creating calls manually.This is also enabled for simple stub flow but NOT enabled for AsyncIO, we'll add that later when start working on AsyncIO Observability.