Set leaf dockerfiles to clean C library before rebuilding#350
Merged
tbetbetbe merged 2 commits intogrpc:masterfrom Feb 3, 2015
murgatroid99:node_dockerfile_fix
Merged
Set leaf dockerfiles to clean C library before rebuilding#350tbetbetbe merged 2 commits intogrpc:masterfrom murgatroid99:node_dockerfile_fix
tbetbetbe merged 2 commits intogrpc:masterfrom
murgatroid99:node_dockerfile_fix
Conversation
Member
|
Any idea why this is necessary? Should we consider fixing make instead? |
Member
Author
|
It's necessary because the C library is actually built in parent docker files. In this particular case, the cached dependencies caused the build to fail because it couldn't find the third party JSON library. Of course, if we are running I don't know if we can fix make to avoid this problem without the guarantee that cached dependencies will never be a problem. |
tbetbetbe
added a commit
that referenced
this pull request
Feb 3, 2015
Set leaf dockerfiles to clean C library before rebuilding
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.