[Python Misc] Revert change to print backtrace in server#34877
Closed
XuanWang-Amos wants to merge 1 commit intogrpc:masterfrom
Closed
[Python Misc] Revert change to print backtrace in server#34877XuanWang-Amos wants to merge 1 commit intogrpc:masterfrom
XuanWang-Amos wants to merge 1 commit intogrpc:masterfrom
Conversation
|
Hi there, any news on when this is going to be released? It's blocking Pulumi on Python 3.12 for everybody :-( |
gnossen
approved these changes
Dec 6, 2023
|
🎉 @XuanWang-Amos, @gnossen, do you know when this will be released? |
paulosjca
pushed a commit
to paulosjca/grpc
that referenced
this pull request
Dec 8, 2023
Fix: grpc#34853 In order to make debugging easier, we have begun printing backtraces in servers. However, this change has the unintended consequence of printing errors to stderr by default, which may not be expected by some users. This PR reverts the change. We recommend that users set up a logging sink if they want to see errors. We will add this to our documentation later. <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> Closes grpc#34877 COPYBARA_INTEGRATE_REVIEW=grpc#34877 from XuanWang-Amos:revert_print_backtrace_change 8942308 PiperOrigin-RevId: 588885550
|
@XuanWang-Amos, when will this be released? Thank you! |
XuanWang-Amos
added a commit
to XuanWang-Amos/grpc
that referenced
this pull request
Jan 5, 2024
Fix: grpc#34853 In order to make debugging easier, we have begun printing backtraces in servers. However, this change has the unintended consequence of printing errors to stderr by default, which may not be expected by some users. This PR reverts the change. We recommend that users set up a logging sink if they want to see errors. We will add this to our documentation later. <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> Closes grpc#34877 COPYBARA_INTEGRATE_REVIEW=grpc#34877 from XuanWang-Amos:revert_print_backtrace_change 8942308 PiperOrigin-RevId: 588885550
veblush
pushed a commit
that referenced
this pull request
Jan 10, 2024
…kport) (#35462) Backport of #34877 to v1.60.x. --- Fix: #34853 In order to make debugging easier, we have begun printing backtraces in servers. However, this change has the unintended consequence of printing errors to stderr by default, which may not be expected by some users. This PR reverts the change. We recommend that users set up a logging sink if they want to see errors. We will add this to our documentation later. <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #34853
In order to make debugging easier, we have begun printing backtraces in servers. However, this change has the unintended consequence of printing errors to stderr by default, which may not be expected by some users.
This PR reverts the change. We recommend that users set up a logging sink if they want to see errors. We will add this to our documentation later.