[chttp2] Bound write sizes based on observed write performance#34665
Merged
ctiller merged 13 commits intogrpc:masterfrom Oct 12, 2023
Hidden character warning
The head ref may contain hidden characters: "\ud83d\udc8c"
Merged
[chttp2] Bound write sizes based on observed write performance#34665ctiller merged 13 commits intogrpc:masterfrom
ctiller merged 13 commits intogrpc:masterfrom
Conversation
Vignesh2208
approved these changes
Oct 12, 2023
ctiller
added a commit
to ctiller/grpc
that referenced
this pull request
Oct 20, 2023
…34665) Instead of fixing a target size for writes, try to adapt it a little to observed bandwidth. The initial algorithm tries to get large writes within 100-1000ms maximum delay - this range probably wants to be tuned, but let's see. The hope here is that on slow connections we can not back buffer so much and so when we need to send a ping-ack it's possible without great delay.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of fixing a target size for writes, try to adapt it a little to observed bandwidth.
The initial algorithm tries to get large writes within 100-1000ms maximum delay - this range probably wants to be tuned, but let's see.
The hope here is that on slow connections we can not back buffer so much and so when we need to send a ping-ack it's possible without great delay.