[chttp2] Add an experiment to separate liveness checks from ping timeouts#34647
Merged
ctiller merged 16 commits intogrpc:masterfrom Oct 12, 2023
Merged
[chttp2] Add an experiment to separate liveness checks from ping timeouts#34647ctiller merged 16 commits intogrpc:masterfrom
ctiller merged 16 commits intogrpc:masterfrom
Conversation
Vignesh2208
approved these changes
Oct 12, 2023
yashykt
reviewed
Oct 12, 2023
| grpc_core::RefCountedPtr<grpc_chttp2_transport> t, | ||
| grpc_error_handle error) { | ||
| // got an incoming read, cancel any pending keepalive timers | ||
| t->keepalive_incoming_data_wanted = false; |
Member
There was a problem hiding this comment.
we are already doing this in read_action_parse_loop_locked?
Member
There was a problem hiding this comment.
oh wait, this is for ping_timeout
Member
There was a problem hiding this comment.
but let's do both in the same place
yashykt
reviewed
Oct 12, 2023
yashykt
reviewed
Oct 12, 2023
| description: | ||
| Keep a different keepalive timeout (resolution is seeing data after sending a ping) | ||
| from a ping timeout (resolution is getting a ping ack after sending a ping) | ||
| The first can be short and determines liveness. |
Member
There was a problem hiding this comment.
It took me some time to parse this. Recommend s/first/keepalive\ timeout and s/second/ping\ timeout
ctiller
added a commit
to ctiller/grpc
that referenced
this pull request
Oct 20, 2023
…outs (grpc#34647) Just seeing data flowing in after a ping is enough to establish liveness of a connection, and so we can limit keepalive timeouts to that. Ping timeouts are necessary for protocol correctness, but may be stuck behind other traffic, so give them a little more of a grace period. --------- Co-authored-by: ctiller <ctiller@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just seeing data flowing in after a ping is enough to establish liveness of a connection, and so we can limit keepalive timeouts to that. Ping timeouts are necessary for protocol correctness, but may be stuck behind other traffic, so give them a little more of a grace period.