[chttp2] Experiments for rst_stream pushback#34642
Merged
ctiller merged 72 commits intogrpc:masterfrom Oct 11, 2023
Merged
Conversation
Automated fix for refs/heads/bitgen
Automated fix for refs/heads/bitgen
Automated fix for refs/heads/bitgen
Automated fix for refs/heads/bitgen
Automated fix for refs/heads/bitgen
Automated fix for refs/heads/ping-v2
markdroth
approved these changes
Oct 10, 2023
|
Does this address GHSA-qppj-fm5r-hxr3 ? |
ctiller
added a commit
to ctiller/grpc
that referenced
this pull request
Oct 20, 2023
Experiment 1: On RST_STREAM: reduce MAX_CONCURRENT_STREAMS for one round trip. Experiment 2: If a settings frame is outstanding with a lower MAX_CONCURRENT_STREAMS than is configured, and we receive a new incoming stream that would exceed the new cap, randomly reject it. --------- Co-authored-by: ctiller <ctiller@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Experiment 1: On RST_STREAM: reduce MAX_CONCURRENT_STREAMS for one round trip.
Experiment 2: If a settings frame is outstanding with a lower MAX_CONCURRENT_STREAMS than is configured, and we receive a new incoming stream that would exceed the new cap, randomly reject it.