[chttp2] Enforce settings acks#34640
Merged
ctiller merged 11 commits intogrpc:masterfrom Oct 10, 2023
Merged
Conversation
markdroth
approved these changes
Oct 10, 2023
| // for implementations taking some more time about acking a setting. | ||
| t_->settings_ack_watchdog = t_->event_engine->RunAfter( | ||
| std::max(t_->keepalive_timeout * 2, | ||
| grpc_core::Duration::Seconds(40)), |
Member
There was a problem hiding this comment.
Should this be configurable via a channel arg or something, in case we need to tune it?
| grpc_core::NewClosure([t](grpc_error_handle) { | ||
| gpr_log(GPR_INFO, "%s: Ping timeout. Closing transport.", | ||
| std::string(t->peer_string.as_string_view()).c_str()); | ||
| send_goaway( |
Member
There was a problem hiding this comment.
Is this actually related to the settings timeout? Seems like this is for a ping timeout, not a settings timeout. Or was this just something unrelated that you noticed while you were duplicating this code for the settings timeout?
Member
Author
There was a problem hiding this comment.
The latter... it came up during code review and didn't seem worth making a new change for (though we can)
ctiller
added a commit
to ctiller/grpc
that referenced
this pull request
Oct 20, 2023
Previously our settings changes carried no timeout, fix that. Default timeout starts at keepalive_timeout*2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously our settings changes carried no timeout, fix that.
Default timeout starts at keepalive_timeout*2.