[chttp2] Limit request count before receiving settings ack#34638
Merged
ctiller merged 9 commits intogrpc:masterfrom Oct 10, 2023
Merged
[chttp2] Limit request count before receiving settings ack#34638ctiller merged 9 commits intogrpc:masterfrom
ctiller merged 9 commits intogrpc:masterfrom
Conversation
markdroth
approved these changes
Oct 10, 2023
| expiry: 2024/01/01 | ||
| owner: ctiller@google.com | ||
| test_tags: [] | ||
| - name: block_excessive_requests_before_settings_ack |
Member
There was a problem hiding this comment.
Does this need an entry in rollouts.yaml?
ctiller
added a commit
to ctiller/grpc
that referenced
this pull request
Oct 20, 2023
Previously chttp2 would allow infinite requests prior to a settings ack - as the agreed upon limit for requests in that state is infinite. Instead, after MAX_CONCURRENT_STREAMS requests have been attempted, start blanket cancelling requests until the settings ack is received. This can be done efficiently without allocating request state structures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously chttp2 would allow infinite requests prior to a settings ack - as the agreed upon limit for requests in that state is infinite.
Instead, after MAX_CONCURRENT_STREAMS requests have been attempted, start blanket cancelling requests until the settings ack is received.
This can be done efficiently without allocating request state structures.