[FuzzingEventEngine] fix TickForDuration() bug and add test#34633
Merged
ctiller merged 3 commits intogrpc:masterfrom Oct 11, 2023
Merged
[FuzzingEventEngine] fix TickForDuration() bug and add test#34633ctiller merged 3 commits intogrpc:masterfrom
ctiller merged 3 commits intogrpc:masterfrom
Conversation
ctiller
approved these changes
Oct 9, 2023
Member
|
Excellent find. |
ctiller
pushed a commit
to ctiller/grpc
that referenced
this pull request
Oct 20, 2023
The `TickForDuration()` method was using `grpc_core::Timestamp::Now()` to get the current time, but that was not in sync with the `now_` value inside the Fuzzing EE itself, with the result that after two subsequent 250ms increments, timers were not being properly fired. I've added a test that demonstrates this failure without the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
TickForDuration()method was usinggrpc_core::Timestamp::Now()to get the current time, but that was not in sync with thenow_value inside the Fuzzing EE itself, with the result that after two subsequent 250ms increments, timers were not being properly fired. I've added a test that demonstrates this failure without the fix.