[fuzzing] Fix timeout in retry_exceeds_buffer_size_in_delay#34627
Merged
ctiller merged 6 commits intogrpc:masterfrom Oct 11, 2023
Merged
[fuzzing] Fix timeout in retry_exceeds_buffer_size_in_delay#34627ctiller merged 6 commits intogrpc:masterfrom
ctiller merged 6 commits intogrpc:masterfrom
Conversation
markdroth
approved these changes
Oct 9, 2023
|
|
||
| #include <grpc/support/log.h> | ||
|
|
||
| grpc_core::TraceFlag grpc_ping_trace(false, "ping"); |
Member
There was a problem hiding this comment.
Maybe call this something like "http2_ping"?
|
|
||
| #include <grpc/support/log.h> | ||
|
|
||
| grpc_core::TraceFlag grpc_ping_trace(false, "ping"); |
Member
There was a problem hiding this comment.
Please document the tracer in doc/environment_variables.md.
|
|
||
| extern gpr_timespec (*gpr_now_impl)(gpr_clock_type clock_type); | ||
|
|
||
| static grpc_core::TraceFlag trace_writes(false, "fee_writes"); |
Member
There was a problem hiding this comment.
I think the "fee_" prefix is going to be confusing. Can we expand that a bit, like maybe "fuzzing_ee_"?
Automated fix for refs/heads/rr
ctiller
added a commit
to ctiller/grpc
that referenced
this pull request
Oct 20, 2023
Fix b/304114403 - adds a new experimental tracer useful for diagnosing ping timeout failures in unit tests - adds a pair of experimental tracers for fuzzing event engine - fix the behavior of FuzzingEventEngine so that a RunAfter(0, ...) runs in the same tick - up the rate of sends (reduce the send delay) so we guarantee to be able to send 200kb/sec in fuzzed e2e unit tests --------- Co-authored-by: ctiller <ctiller@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix b/304114403