[chttp2] Delay starting ping timeout timer until writes complete#34589
Merged
ctiller merged 5 commits intogrpc:masterfrom Oct 5, 2023
Merged
[chttp2] Delay starting ping timeout timer until writes complete#34589ctiller merged 5 commits intogrpc:masterfrom
ctiller merged 5 commits intogrpc:masterfrom
Conversation
…ng timeout have completed
yashykt
reviewed
Oct 4, 2023
| return started_new_ping_without_setting_timeout_; | ||
| } | ||
|
|
||
| void OnPingTimeout(Duration ping_timeout, |
yashykt
reviewed
Oct 4, 2023
| auto id = callbacks.StartPing( | ||
| bitgen, Duration::Hours(24), [] { Crash("should not reach here"); }, | ||
| &event_engine); | ||
| auto id = callbacks.StartPing(bitgen); |
Member
There was a problem hiding this comment.
do we have a test that acks the ping before the timeout is started?
yashykt
approved these changes
Oct 4, 2023
ctiller
added a commit
to ctiller/grpc
that referenced
this pull request
Oct 20, 2023
…c#34589) We probably shouldn't count the time it takes us to write out data as part of the ping timeout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We probably shouldn't count the time it takes us to write out data as part of the ping timeout