Skip to content

[Cord] Fix MakeCordFromSlice memory bug#34549

Merged
veblush merged 2 commits intogrpc:masterfrom
veblush:fix-c-f
Sep 29, 2023
Merged

[Cord] Fix MakeCordFromSlice memory bug#34549
veblush merged 2 commits intogrpc:masterfrom
veblush:fix-c-f

Conversation

@veblush
Copy link
Copy Markdown
Contributor

@veblush veblush commented Sep 29, 2023

Fix MakeCordFromSlice function to fail to carry an inlined slice which can give a corrupted result when deserializing a Cord.

@veblush veblush added kind/bug lang/c++ release notes: no Indicates if PR should not be in release notes labels Sep 29, 2023
@veblush veblush changed the title Fix MakeCordFromSlice memory bug [Cord] Fix MakeCordFromSlice memory bug Sep 29, 2023
@veblush veblush enabled auto-merge (squash) September 29, 2023 17:40
@veblush veblush disabled auto-merge September 29, 2023 21:09
@veblush veblush merged commit 4fa02ac into grpc:master Sep 29, 2023
veblush added a commit to veblush/grpc that referenced this pull request Sep 29, 2023
Fix `MakeCordFromSlice` function to fail to carry an inlined slice which
can give a corrupted result when deserializing a Cord.
veblush added a commit to veblush/grpc that referenced this pull request Sep 29, 2023
Fix `MakeCordFromSlice` function to fail to carry an inlined slice which
can give a corrupted result when deserializing a Cord.
veblush added a commit that referenced this pull request Sep 29, 2023
veblush added a commit to veblush/grpc that referenced this pull request Sep 30, 2023
Fix `MakeCordFromSlice` function to fail to carry an inlined slice which
can give a corrupted result when deserializing a Cord.
veblush added a commit to veblush/grpc that referenced this pull request Sep 30, 2023
Fix `MakeCordFromSlice` function to fail to carry an inlined slice which
can give a corrupted result when deserializing a Cord.
veblush added a commit to veblush/grpc that referenced this pull request Sep 30, 2023
Fix `MakeCordFromSlice` function to fail to carry an inlined slice which
can give a corrupted result when deserializing a Cord.
@copybara-service copybara-service bot added the imported Specifies if the PR has been imported to the internal repository label Sep 30, 2023
veblush added a commit that referenced this pull request Oct 6, 2023
veblush added a commit that referenced this pull request Oct 6, 2023
veblush added a commit that referenced this pull request Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bloat/none imported Specifies if the PR has been imported to the internal repository kind/bug lang/c++ per-call-memory/neutral per-channel-memory/neutral release notes: no Indicates if PR should not be in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants