Merged
Conversation
eugeneo
approved these changes
Sep 22, 2023
Contributor
|
This breaks the Bazel RBE Non-Bazel Tests completely by not updating |
jtattermusch
added a commit
to jtattermusch/grpc
that referenced
this pull request
Sep 25, 2023
jtattermusch
added a commit
to jtattermusch/grpc
that referenced
this pull request
Sep 25, 2023
jtattermusch
added a commit
that referenced
this pull request
Sep 25, 2023
Unbreak what was broken by #34444 (comment).
veblush
added a commit
that referenced
this pull request
Sep 25, 2023
Changed missing piece of #34444
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumping gcc 7 to 8 to workaround the ongoing gcc segfault problem when building Protobuf C++. Currently Foundational C++ requires gcc 7 so this is a temporary measure to make the test green. We need to either make a decision to change the minimum version of gcc in the Foundational C++ or find a way to support gcc 7 without gcc segfault soon.