[EventEngine] Delete OriginalThreadPool, remove work_stealing experiment#34315
Merged
drfloob merged 5 commits intogrpc:masterfrom Sep 15, 2023
Merged
[EventEngine] Delete OriginalThreadPool, remove work_stealing experiment#34315drfloob merged 5 commits intogrpc:masterfrom
drfloob merged 5 commits intogrpc:masterfrom
Conversation
…riment
This has been stable for a couple of weeks, everywhere that the EventEngine is enabled. Going forward, the event_engine_{client|listener} experiments can probably be used to regulate thread-pool-specific issues.
Automated fix for refs/heads/rm-original-thread-pool
ctiller
approved these changes
Sep 12, 2023
| // Our first thread pool implementation tried to create ~1M threads for this | ||
| // test. | ||
| int branch_factor = 18; | ||
| int branch_factor = 20; |
Member
There was a problem hiding this comment.
what's the impact on runtime for this?
Member
Author
There was a problem hiding this comment.
Trivial. Runtime with a 20x branch factor on Linux RBE is 180ms. With the OriginalThreadPool, it was minutes.
drfloob
added a commit
that referenced
this pull request
Sep 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been stable for a bit, everywhere that the EventEngine is enabled. Going forward, I think the event_engine_{client|listener} experiments can probably be used to regulate thread-pool-specific issues.