[Deps] Adding upb as a submodule#34199
Conversation
|
Failing tests are caused by changing subtree to submodule. This won't happen once this is merged. |
|
Hm, IMHO changing upb into a submodule isn't really possible without also switching our cmake build to using the upb's CMakeLists.txt (since for anything that isn't vendored in our repo directly, we need to depend on a properly installable library). Looks like this PR is breaking the C++ distribtests precisely for this reason: So more followup work is needed. |
Is there anything tracking this followup work? As far as I understand it, this commit violated this invariant: https://github.com/grpc/grpc/blob/master/third_party/README.md
Since we can no longer build/install gRPC if the upb submodule is not present, even if it is already installed. |
|
It also looks like upb itself may not support building via cmake: |
Temporary gRPC is vendoing upb again until upb has a cmake support. (Rollback of #34199)
Let's make it as a regular dependency like others. So gRPC is now unvendoring it first. Project generation part will be followed later.