[PSM Interop] Enable xDS custom LB test for Node#34146
[PSM Interop] Enable xDS custom LB test for Node#34146murgatroid99 merged 1 commit intogrpc:masterfrom
Conversation
|
Running a lb tests using framework from this branch, and grpc-node code from grpc/grpc-node#2555. |
|
It looks like the custom LB test didn't run in that test job, but I merged the Node repo PR, so running it against master should work now. |
|
@murgatroid99 I see - it didn't run because it's not in https://github.com/grpc/grpc-node/blob/354bd2d5c3c88ab736be669fcc245e64f4f352dd/packages/grpc-js-xds/scripts/xds_k8s_lb.sh#L168. Could you please add it to the list, but also format and sort this list as we did here? grpc/tools/internal_ci/linux/grpc_xds_k8s_lb.sh Lines 172 to 182 in b980f62 Let me know when the PR is ready - I'll run tests against it. |
|
I filed that PR in grpc/grpc-node#2557. |
|
Failed: Traceback (most recent call last):
File "/tmp/tmp.CXtkTaZSEp/grpc/tools/run_tests/xds_k8s_test_driver/tests/custom_lb_test.py", line 120, in test_custom_lb_config
self.assertRpcStatusCodes(
File "/tmp/tmp.CXtkTaZSEp/grpc/tools/run_tests/xds_k8s_test_driver/framework/xds_k8s_testcase.py", line 410, in assertRpcStatusCodes
self.fail(
AssertionError: Expected only status (15, DATA_LOSS), but found status (0, OK) for method UNARY_CALL.Diff stats:
- method: UNARY_CALL
rpcs_started: 247
result:
(0, OK): 247 |
|
The test passed. The bugfix is in the same PR that enabled the test. |
sergiitk
left a comment
There was a problem hiding this comment.
LGTM, but please make sure to merge the node change to master first (needed to not break staging)
Similar to #34146, this will only run on master for now. This will work after grpc/grpc-node#2568 is merged.
v1.10.x is the next version, so this will only run on master for now. This won't work until grpc/grpc-node#2555 is merged.
Similar to grpc#34146, this will only run on master for now. This will work after grpc/grpc-node#2568 is merged.
v1.10.x is the next version, so this will only run on master for now. This won't work until grpc/grpc-node#2555 is merged.