Implement full logic of publish and subscribe#341
Merged
yang-g merged 7 commits intogrpc:masterfrom Feb 3, 2015
chen-wang:master
Merged
Implement full logic of publish and subscribe#341yang-g merged 7 commits intogrpc:masterfrom chen-wang:master
yang-g merged 7 commits intogrpc:masterfrom
chen-wang:master
Conversation
examples/tips/main.cc
Outdated
Contributor
There was a problem hiding this comment.
This was static because I need to use it twice. Here since you only need it once, maybe a local string will do.
Contributor
There was a problem hiding this comment.
maybe change the function body to
std::ifstream json_key_file(FLAGS_service_account_key_file);
std::stringstream key_stream;
key_stream << json_key_file.rdbuf();
return key_stream.str();
yang-g
added a commit
that referenced
this pull request
Feb 3, 2015
Implement full logic of publish and subscribe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.