Revert "[c-ares DNS resolver] Fix file descriptor use-after-close bug when c-ares writes succeed but subsequent read fails"#33934
Merged
ananda1066 merged 1 commit intomasterfrom Aug 1, 2023
Conversation
yijiem
approved these changes
Jul 31, 2023
apolcyn
added a commit
to apolcyn/grpc
that referenced
this pull request
Aug 1, 2023
…lose bug when c-ares writes succeed but subsequent read fails" (grpc#33934)" This reverts commit 9aca06d.
apolcyn
added a commit
that referenced
this pull request
Aug 1, 2023
…descriptor use-after-close bug when c-ares writes succeed but subsequent read fails" (#33934)" (#33942) Rolls forward #33871 Second and third commits here fix internal build issues In particular, add a `// IWYU pragma: no_include <ares_build.h>` since `ares.h` [includes that anyways](https://github.com/c-ares/c-ares/blob/bad62225b7f6b278b92e8e85a255600b629ef517/include/ares.h#L23) (and seems unlikely for that to change since it would be breaking)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #33871 due to build failures in google3.