[ruby] fix crash when prefork/postfork is used without previously using grpc#33788
Merged
apolcyn merged 2 commits intogrpc:masterfrom Jul 20, 2023
Merged
[ruby] fix crash when prefork/postfork is used without previously using grpc#33788apolcyn merged 2 commits intogrpc:masterfrom
apolcyn merged 2 commits intogrpc:masterfrom
Conversation
| // sure basic one-time initialization is taken care of. Note that if this is | ||
| // the case, then grpc_init() will start up c-core threads; that's OK since | ||
| // they will be shut down in C-core's pthread_atfork handler. | ||
| gpr_once_init(&g_once_init, grpc_ruby_basic_init); |
Contributor
There was a problem hiding this comment.
I had a different solution that didn't involve initializing the threads: Shopify@6277075
But I guess this is OK.
Contributor
Author
There was a problem hiding this comment.
Your fix also looks OK, but I'll favor the fix here for simplicity - I want to minimize the fork related state we track for maintainability.
drfloob
approved these changes
Jul 20, 2023
casperisfine
pushed a commit
to Shopify/grpc
that referenced
this pull request
Jul 20, 2023
mario-vimal
pushed a commit
to mario-vimal/grpc
that referenced
this pull request
Jul 27, 2023
…ng grpc (grpc#33788) Should fix grpc#33787
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix #33787