[print backtrace] Print exception backtrace for all exceptions by XuanWang-Amos · Pull Request #33442 · grpc/grpc

XuanWang-Amos · 2023-06-14T20:36:27Z

Action item from: #33364

Before change:

Printable Exception (Only printing exception):

ERROR:grpc._server:Exception calling application: Test exception
Traceback (most recent call last):
  File "/usr/local/google/home/xuanwn/.cache/bazel/_bazel_xuanwn/da3828576aa39e99a5c826cc2e2e22fb/sandbox/linux-sandbox/2110/execroot/com_github_grpc_grpc/bazel-out/k8-fastbuild/bin/src/python/grpcio_tests/tests/unit/_metadata_test.native.runfiles/com_github_grpc_grpc/src/python/grpcio/grpc/_server.py", line 561, in _call_behavior
    raise TestException
grpc._server.TestException: Test exception
ERROR

Un-Printable Exception (Only printing traceback):

Traceback (most recent call last):
  File "/usr/local/google/home/xuanwn/.cache/bazel/_bazel_xuanwn/da3828576aa39e99a5c826cc2e2e22fb/sandbox/linux-sandbox/2112/execroot/com_github_grpc_grpc/bazel-out/k8-fastbuild/bin/src/python/grpcio_tests/tests/unit/_metadata_test.native.runfiles/com_github_grpc_grpc/src/python/grpcio/grpc/_server.py", line 561, in _call_behavior
    raise TestException
grpc._server.TestException: <unprintable TestException object>

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/google/home/xuanwn/.cache/bazel/_bazel_xuanwn/da3828576aa39e99a5c826cc2e2e22fb/sandbox/linux-sandbox/2112/execroot/com_github_grpc_grpc/bazel-out/k8-fastbuild/bin/src/python/grpcio_tests/tests/unit/_metadata_test.native.runfiles/com_github_grpc_grpc/src/python/grpcio/grpc/_server.py", line 574, in _call_behavior
    details = "Exception calling application: {}".format(
  File "/usr/local/google/home/xuanwn/.cache/bazel/_bazel_xuanwn/da3828576aa39e99a5c826cc2e2e22fb/sandbox/linux-sandbox/2112/execroot/com_github_grpc_grpc/bazel-out/k8-fastbuild/bin/src/python/grpcio_tests/tests/unit/_metadata_test.native.runfiles/com_github_grpc_grpc/src/python/grpcio/grpc/_server.py", line 536, in __str__
    return 'Test exception {0}'.format(self.val)
AttributeError: 'TestException' object has no attribute 'val'
ERROR:grpc._server:Calling application raised unprintable Exception!
Traceback (most recent call last):
  File "/usr/local/google/home/xuanwn/.cache/bazel/_bazel_xuanwn/da3828576aa39e99a5c826cc2e2e22fb/sandbox/linux-sandbox/2112/execroot/com_github_grpc_grpc/bazel-out/k8-fastbuild/bin/src/python/grpcio_tests/tests/unit/_metadata_test.native.runfiles/com_github_grpc_grpc/src/python/grpcio/grpc/_server.py", line 561, in _call_behavior
    raise TestException
grpc._server.TestException: <unprintable TestException object>
ERROR

After change:

Printable Exception (Printing both exception and traceback):

Traceback (most recent call last):
  File "/usr/local/google/home/xuanwn/.cache/bazel/_bazel_xuanwn/da3828576aa39e99a5c826cc2e2e22fb/sandbox/linux-sandbox/2114/execroot/com_github_grpc_grpc/bazel-out/k8-fastbuild/bin/src/python/grpcio_tests/tests/unit/_metadata_test.native.runfiles/com_github_grpc_grpc/src/python/grpcio/grpc/_server.py", line 561, in _call_behavior
    raise TestException
grpc._server.TestException: Test exception
ERROR:grpc._server:Exception calling application: Test exception
Traceback (most recent call last):
  File "/usr/local/google/home/xuanwn/.cache/bazel/_bazel_xuanwn/da3828576aa39e99a5c826cc2e2e22fb/sandbox/linux-sandbox/2114/execroot/com_github_grpc_grpc/bazel-out/k8-fastbuild/bin/src/python/grpcio_tests/tests/unit/_metadata_test.native.runfiles/com_github_grpc_grpc/src/python/grpcio/grpc/_server.py", line 561, in _call_behavior
    raise TestException
grpc._server.TestException: Test exception
ERROR

Un-Printable Exception (Printing both exception and traceback):

ERROR:grpc._server:['Traceback (most recent call last):\n', '  File "/usr/local/google/home/xuanwn/.cache/bazel/_bazel_xuanwn/da3828576aa39e99a5c826cc2e2e22fb/sandbox/linux-sandbox/2116/execroot/com_github_grpc_grpc/bazel-out/k8-fastbuild/bin/src/python/grpcio_tests/tests/unit/_metadata_test.native.runfiles/com_github_grpc_grpc/src/python/grpcio/grpc/_server.py", line 561, in _call_behavior\n    raise TestException\n', 'grpc._server.TestException: <unprintable TestException object>\n']
Traceback (most recent call last):
  File "/usr/local/google/home/xuanwn/.cache/bazel/_bazel_xuanwn/da3828576aa39e99a5c826cc2e2e22fb/sandbox/linux-sandbox/2116/execroot/com_github_grpc_grpc/bazel-out/k8-fastbuild/bin/src/python/grpcio_tests/tests/unit/_metadata_test.native.runfiles/com_github_grpc_grpc/src/python/grpcio/grpc/_server.py", line 561, in _call_behavior
    raise TestException
grpc._server.TestException: <unprintable TestException object>

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/google/home/xuanwn/.cache/bazel/_bazel_xuanwn/da3828576aa39e99a5c826cc2e2e22fb/sandbox/linux-sandbox/2116/execroot/com_github_grpc_grpc/bazel-out/k8-fastbuild/bin/src/python/grpcio_tests/tests/unit/_metadata_test.native.runfiles/com_github_grpc_grpc/src/python/grpcio/grpc/_server.py", line 574, in _call_behavior
    details = "Exception calling application: {}".format(
  File "/usr/local/google/home/xuanwn/.cache/bazel/_bazel_xuanwn/da3828576aa39e99a5c826cc2e2e22fb/sandbox/linux-sandbox/2116/execroot/com_github_grpc_grpc/bazel-out/k8-fastbuild/bin/src/python/grpcio_tests/tests/unit/_metadata_test.native.runfiles/com_github_grpc_grpc/src/python/grpcio/grpc/_server.py", line 536, in __str__
    return 'Test exception {0}'.format(self.val)
AttributeError: 'TestException' object has no attribute 'val'
Traceback (most recent call last):
  File "/usr/local/google/home/xuanwn/.cache/bazel/_bazel_xuanwn/da3828576aa39e99a5c826cc2e2e22fb/sandbox/linux-sandbox/2116/execroot/com_github_grpc_grpc/bazel-out/k8-fastbuild/bin/src/python/grpcio_tests/tests/unit/_metadata_test.native.runfiles/com_github_grpc_grpc/src/python/grpcio/grpc/_server.py", line 561, in _call_behavior
    raise TestException
grpc._server.TestException: <unprintable TestException object>
ERROR:grpc._server:Calling application raised unprintable Exception!
Traceback (most recent call last):
  File "/usr/local/google/home/xuanwn/.cache/bazel/_bazel_xuanwn/da3828576aa39e99a5c826cc2e2e22fb/sandbox/linux-sandbox/2116/execroot/com_github_grpc_grpc/bazel-out/k8-fastbuild/bin/src/python/grpcio_tests/tests/unit/_metadata_test.native.runfiles/com_github_grpc_grpc/src/python/grpcio/grpc/_server.py", line 561, in _call_behavior
    raise TestException
grpc._server.TestException: <unprintable TestException object>
ERROR

gnossen · 2023-06-15T17:04:24Z

src/python/grpcio/grpc/_server.py

                        )
-                        traceback.print_exc()
+                    traceback.print_exc()
                    _LOGGER.exception(details)


As discussed, let's also log this via the _LOGGER. This will ensure that the message shows up:

On STDERR when no logging sink has been configured.

In the log file, if it is not combined with STDERR.

Sure, since we're already logging printable exceptions, I'll just add _LOGGER support for un-printable exceptions.

gnossen · 2023-06-15T17:04:44Z

Please manually test and link the logs to the PR.

XuanWang-Amos · 2023-07-26T00:13:24Z

Please manually test and link the logs to the PR.

Added to PR description.

#33442)" This reverts commit 9e5c365.

…33442) Action item from: grpc#33364  ### Before change: * Printable Exception (Only printing exception): ``` ERROR:grpc._server:Exception calling application: Test exception Traceback (most recent call last): File "/usr/local/google/home/xuanwn/.cache/bazel/_bazel_xuanwn/da3828576aa39e99a5c826cc2e2e22fb/sandbox/linux-sandbox/2110/execroot/com_github_grpc_grpc/bazel-out/k8-fastbuild/bin/src/python/grpcio_tests/tests/unit/_metadata_test.native.runfiles/com_github_grpc_grpc/src/python/grpcio/grpc/_server.py", line 561, in _call_behavior raise TestException grpc._server.TestException: Test exception ERROR ``` * Un-Printable Exception (Only printing traceback): ``` Traceback (most recent call last): File "/usr/local/google/home/xuanwn/.cache/bazel/_bazel_xuanwn/da3828576aa39e99a5c826cc2e2e22fb/sandbox/linux-sandbox/2112/execroot/com_github_grpc_grpc/bazel-out/k8-fastbuild/bin/src/python/grpcio_tests/tests/unit/_metadata_test.native.runfiles/com_github_grpc_grpc/src/python/grpcio/grpc/_server.py", line 561, in _call_behavior raise TestException grpc._server.TestException: <unprintable TestException object> During handling of the above exception, another exception occurred: Traceback (most recent call last): File "/usr/local/google/home/xuanwn/.cache/bazel/_bazel_xuanwn/da3828576aa39e99a5c826cc2e2e22fb/sandbox/linux-sandbox/2112/execroot/com_github_grpc_grpc/bazel-out/k8-fastbuild/bin/src/python/grpcio_tests/tests/unit/_metadata_test.native.runfiles/com_github_grpc_grpc/src/python/grpcio/grpc/_server.py", line 574, in _call_behavior details = "Exception calling application: {}".format( File "/usr/local/google/home/xuanwn/.cache/bazel/_bazel_xuanwn/da3828576aa39e99a5c826cc2e2e22fb/sandbox/linux-sandbox/2112/execroot/com_github_grpc_grpc/bazel-out/k8-fastbuild/bin/src/python/grpcio_tests/tests/unit/_metadata_test.native.runfiles/com_github_grpc_grpc/src/python/grpcio/grpc/_server.py", line 536, in __str__ return 'Test exception {0}'.format(self.val) AttributeError: 'TestException' object has no attribute 'val' ERROR:grpc._server:Calling application raised unprintable Exception! Traceback (most recent call last): File "/usr/local/google/home/xuanwn/.cache/bazel/_bazel_xuanwn/da3828576aa39e99a5c826cc2e2e22fb/sandbox/linux-sandbox/2112/execroot/com_github_grpc_grpc/bazel-out/k8-fastbuild/bin/src/python/grpcio_tests/tests/unit/_metadata_test.native.runfiles/com_github_grpc_grpc/src/python/grpcio/grpc/_server.py", line 561, in _call_behavior raise TestException grpc._server.TestException: <unprintable TestException object> ERROR ``` ### After change: * Printable Exception (Printing both exception and traceback): ``` Traceback (most recent call last): File "/usr/local/google/home/xuanwn/.cache/bazel/_bazel_xuanwn/da3828576aa39e99a5c826cc2e2e22fb/sandbox/linux-sandbox/2114/execroot/com_github_grpc_grpc/bazel-out/k8-fastbuild/bin/src/python/grpcio_tests/tests/unit/_metadata_test.native.runfiles/com_github_grpc_grpc/src/python/grpcio/grpc/_server.py", line 561, in _call_behavior raise TestException grpc._server.TestException: Test exception ERROR:grpc._server:Exception calling application: Test exception Traceback (most recent call last): File "/usr/local/google/home/xuanwn/.cache/bazel/_bazel_xuanwn/da3828576aa39e99a5c826cc2e2e22fb/sandbox/linux-sandbox/2114/execroot/com_github_grpc_grpc/bazel-out/k8-fastbuild/bin/src/python/grpcio_tests/tests/unit/_metadata_test.native.runfiles/com_github_grpc_grpc/src/python/grpcio/grpc/_server.py", line 561, in _call_behavior raise TestException grpc._server.TestException: Test exception ERROR ``` * Un-Printable Exception (Printing both exception and traceback): ``` ERROR:grpc._server:['Traceback (most recent call last):\n', ' File "/usr/local/google/home/xuanwn/.cache/bazel/_bazel_xuanwn/da3828576aa39e99a5c826cc2e2e22fb/sandbox/linux-sandbox/2116/execroot/com_github_grpc_grpc/bazel-out/k8-fastbuild/bin/src/python/grpcio_tests/tests/unit/_metadata_test.native.runfiles/com_github_grpc_grpc/src/python/grpcio/grpc/_server.py", line 561, in _call_behavior\n raise TestException\n', 'grpc._server.TestException: <unprintable TestException object>\n'] Traceback (most recent call last): File "/usr/local/google/home/xuanwn/.cache/bazel/_bazel_xuanwn/da3828576aa39e99a5c826cc2e2e22fb/sandbox/linux-sandbox/2116/execroot/com_github_grpc_grpc/bazel-out/k8-fastbuild/bin/src/python/grpcio_tests/tests/unit/_metadata_test.native.runfiles/com_github_grpc_grpc/src/python/grpcio/grpc/_server.py", line 561, in _call_behavior raise TestException grpc._server.TestException: <unprintable TestException object> During handling of the above exception, another exception occurred: Traceback (most recent call last): File "/usr/local/google/home/xuanwn/.cache/bazel/_bazel_xuanwn/da3828576aa39e99a5c826cc2e2e22fb/sandbox/linux-sandbox/2116/execroot/com_github_grpc_grpc/bazel-out/k8-fastbuild/bin/src/python/grpcio_tests/tests/unit/_metadata_test.native.runfiles/com_github_grpc_grpc/src/python/grpcio/grpc/_server.py", line 574, in _call_behavior details = "Exception calling application: {}".format( File "/usr/local/google/home/xuanwn/.cache/bazel/_bazel_xuanwn/da3828576aa39e99a5c826cc2e2e22fb/sandbox/linux-sandbox/2116/execroot/com_github_grpc_grpc/bazel-out/k8-fastbuild/bin/src/python/grpcio_tests/tests/unit/_metadata_test.native.runfiles/com_github_grpc_grpc/src/python/grpcio/grpc/_server.py", line 536, in __str__ return 'Test exception {0}'.format(self.val) AttributeError: 'TestException' object has no attribute 'val' Traceback (most recent call last): File "/usr/local/google/home/xuanwn/.cache/bazel/_bazel_xuanwn/da3828576aa39e99a5c826cc2e2e22fb/sandbox/linux-sandbox/2116/execroot/com_github_grpc_grpc/bazel-out/k8-fastbuild/bin/src/python/grpcio_tests/tests/unit/_metadata_test.native.runfiles/com_github_grpc_grpc/src/python/grpcio/grpc/_server.py", line 561, in _call_behavior raise TestException grpc._server.TestException: <unprintable TestException object> ERROR:grpc._server:Calling application raised unprintable Exception! Traceback (most recent call last): File "/usr/local/google/home/xuanwn/.cache/bazel/_bazel_xuanwn/da3828576aa39e99a5c826cc2e2e22fb/sandbox/linux-sandbox/2116/execroot/com_github_grpc_grpc/bazel-out/k8-fastbuild/bin/src/python/grpcio_tests/tests/unit/_metadata_test.native.runfiles/com_github_grpc_grpc/src/python/grpcio/grpc/_server.py", line 561, in _call_behavior raise TestException grpc._server.TestException: <unprintable TestException object> ERROR ```

github-actions bot added the lang/Python label Jun 14, 2023

XuanWang-Amos added the release notes: no Indicates if PR should not be in release notes label Jun 14, 2023

XuanWang-Amos assigned gnossen Jun 15, 2023

XuanWang-Amos requested a review from gnossen June 15, 2023 16:47

XuanWang-Amos marked this pull request as ready for review June 15, 2023 16:47

gnossen reviewed Jun 15, 2023

View reviewed changes

[print backtrace] Print exception backtrace for all exceptions

0651477

XuanWang-Amos force-pushed the printExp branch from df811a8 to 0651477 Compare July 25, 2023 23:12

XuanWang-Amos added 2 commits July 26, 2023 00:13

Add _LOGGER support for un-printable exceptions

77dbff7

Fix pylint

215e2a2

gnossen approved these changes Jul 27, 2023

View reviewed changes

Fix pylint

5c84af7

XuanWang-Amos merged commit 9e5c365 into grpc:master Jul 27, 2023

XuanWang-Amos deleted the printExp branch July 27, 2023 19:16

XuanWang-Amos added a commit that referenced this pull request Jul 27, 2023

Revert "[print backtrace] Print exception backtrace for all exceptions (

4dcfe8f

#33442)" This reverts commit 9e5c365.

XuanWang-Amos mentioned this pull request Jul 27, 2023

Revert "[print backtrace] Print exception backtrace for all exceptions" #33903

Closed

copybara-service bot added the imported Specifies if the PR has been imported to the internal repository label Jul 27, 2023

This was referenced Oct 31, 2023

After 3.90.0 diagnostic for pulumi/dynamic CheckConfig/DiffConfig starts being printed pulumi/pulumi#14442

Closed

Regression: Calling an unimplemented method causes a traceback to be emitted to stderr in the server process #34853

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[print backtrace] Print exception backtrace for all exceptions#33442

[print backtrace] Print exception backtrace for all exceptions#33442
XuanWang-Amos merged 4 commits intogrpc:masterfrom
XuanWang-Amos:printExp

XuanWang-Amos commented Jun 14, 2023 •

edited

Loading

Uh oh!

gnossen Jun 15, 2023

Uh oh!

XuanWang-Amos Jul 26, 2023

Uh oh!

gnossen commented Jun 15, 2023

Uh oh!

XuanWang-Amos commented Jul 26, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

XuanWang-Amos commented Jun 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Before change:

After change:

Uh oh!

gnossen Jun 15, 2023

Choose a reason for hiding this comment

Uh oh!

XuanWang-Amos Jul 26, 2023

Choose a reason for hiding this comment

Uh oh!

gnossen commented Jun 15, 2023

Uh oh!

XuanWang-Amos commented Jul 26, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

XuanWang-Amos commented Jun 14, 2023 •

edited

Loading