[Test] Dedup vs2019 test in the Windows test#33385
Merged
veblush merged 2 commits intogrpc:masterfrom Jun 9, 2023
Merged
Conversation
ctiller
approved these changes
Jun 9, 2023
veblush
added a commit
that referenced
this pull request
Jun 9, 2023
mario-vimal
pushed a commit
to mario-vimal/grpc
that referenced
this pull request
Jun 15, 2023
`cmake_ninja_vs2019` and `default` are using the same `cmake_ninja_vs2019` so having two tests are waste so this is removing `cmake_ninja_vs2019` leaving `default` which does `cmake_ninja_vs2019`. This change can cut the space consumption by half and with 250GB disc, - Pre-test: 267,770,322,944 bytes free - Post-test: 134,499,295,232 bytes free
mario-vimal
pushed a commit
to mario-vimal/grpc
that referenced
this pull request
Jun 15, 2023
Reverts grpc#33385 Temporary revert to unblock grpc#33138
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cmake_ninja_vs2019anddefaultare using the samecmake_ninja_vs2019so having two tests are waste so this is removingcmake_ninja_vs2019leavingdefaultwhich doescmake_ninja_vs2019.This change can cut the space consumption by half and with 250GB disc,