[core] Add support for vsock transport#33309
Conversation
This reverts commit c5ade30.
AF_VSOCK is introduced in sys/socket.h since glibc-v2.18 and musl-libc-v0.9.12. So add AF_VSOCK check to guard GRPC_HAVE_VSOCK.
|
I took the liberty of pushing a formatting fix to your branch (please pull again before you attempt to push another commit, if necessary). |
|
@drfloob the preprocessor is reporting error preprocessor will interpret I submitted new commit to fix this, please review it. |
drfloob
left a comment
There was a problem hiding this comment.
This looks good to me. There is an unrelated breakage in the python distribution tests, I've pinged the team about it. @gnossen @XuanWang-Amos: I believe we've solved the issue in this PR that broke the python distribution tests last time we merged. Should we merge this PR, or wait for the CI job to get fixed?
|
Update: @XuanWang-Amos is working on the python distribution test breakage, we can wait another day or so to be safe, or risk another rollback-fix-reland cycle if we merge before then. |
|
The Python distribtests fix was merged, and the test is passing on this PR. Merging. Thanks for the great work, @YadongQi. |
gRPC recently merged support for Virtio VSOCK as transport. It would be helpful for us if tonic were to match gRPC's support for it. gRPC PR that adds VSOCK support: grpc/grpc#33309
gRPC recently merged support for Virtio VSOCK as transport. It would be helpful for us if tonic were to match gRPC's support for it. gRPC PR that adds VSOCK support: grpc/grpc#33309
Revert "Revert "[core] Add support for vsock transport" (grpc#33276)" This reverts commit grpc@c5ade30. And fix the issue which broke the python build. @markdroth @drfloob please review this PR. Thank you very much. --------- Co-authored-by: AJ Heller <hork@google.com>
Local modifications: - Forward port the VSOCK patch based on upstream: grpc/grpc#33309 - Forward port the addition of an empty constructor to FilterChainData to work around a compiler issue. Bug: 279548314 Test: presubmit, cuttlefish_wmediumd_control_test https://android-build.corp.google.com/abtd/run/L20300000963548848/ Change-Id: I6a033f1ea32881a6cbe3958e3ec7efb9b60103ef
Local modifications: - Update VSOCK patch based on grpc/grpc#33309 Bug: 279548314 Test: presubmit, cuttlefish_wmediumd_control_test https://android-build.corp.google.com/builds/abtd/run/L06600000963778207 Change-Id: Ie8f4a93029902e9ead40cb7f2ec6293b2028c78a
Revert "Revert "[core] Add support for vsock transport" (#33276)"
This reverts commit c5ade30.
And fix the issue which broke the python build.
@markdroth @drfloob please review this PR. Thank you very much.