[ObjC] Upgrade podspec xx.deployment_target#33091
Merged
HannahShiSFB merged 1 commit intogrpc:masterfrom May 20, 2023
Merged
Conversation
c951b1e to
fb74235
Compare
fb74235 to
bc4f9e6
Compare
bc4f9e6 to
efc9eae
Compare
d0017b8 to
b03444a
Compare
sampajano
approved these changes
May 18, 2023
Contributor
sampajano
left a comment
There was a problem hiding this comment.
Wow.. that's a lot of podspecs that we have..... 😂
Thanks so much for figuring this out, Hannah.. Great investigative work... 😄
@mikefan1991 FYI
Contributor
|
@HannahShiSFB can you fix the "Mergeable" CI failure too? I think you can modify some labels and it should work :) |
b03444a to
5cce36e
Compare
eugeneo
pushed a commit
to eugeneo/grpc
that referenced
this pull request
Jun 1, 2023
Upgrade apple platform deployment_target versions to fix the cocoapods push of BoringSSL-GRPC about the following error: ``` ld: file not found: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/arc/libarclite_macosx.a clang: error: linker command failed with exit code 1 (use -v to see invocation) ``` ref: https://developer.apple.com/forums/thread/725300 This also aligns with the versions required by [protobuf](protocolbuffers/protobuf#10652) ``` ios.deployment_target = '10.0' osx.deployment_target = '10.12' tvos.deployment_target = '12.0' watchos.deployment_target = '6.0' ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade apple platform deployment_target versions to fix the cocoapods push of BoringSSL-GRPC about the following error:
ref: https://developer.apple.com/forums/thread/725300
This also aligns with the versions required by protobuf