[infra] Backport: Ensure compatibility with the new custom kokoro win2019 image (#32649)#33052
Merged
veblush merged 2 commits intogrpc:v1.52.xfrom May 9, 2023
Merged
Conversation
…2649) Fix incompatibilities identified when running adhoc runs on the new custom win2019 image. After merging this, it should be possible to switch to the new image without breaking any tests. - for most fixes I added a comment that explains why they're necessary. - the new image won't have VS2015 installed, so I'm switching the protoc artifact build to VS2017 This PR will need to be backported to older release branches to ensure the windows tests continue working on those branches as well (IMHO I haven't made any changes that would be difficult to backport and I tried to keeps the diff as small as possible to avoid issues when backporting). After we switch to the new image (and all the windows tests are green), we can incrementally move the builds that are still using VS2017 to VS2019.
apolcyn
approved these changes
May 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix incompatibilities identified when running adhoc runs on the new custom win2019 image.
After merging this, it should be possible to switch to the new image without breaking any tests.
This PR will need to be backported to older release branches to ensure the windows tests continue working on those branches as well (IMHO I haven't made any changes that would be difficult to backport and I tried to keeps the diff as small as possible to avoid issues when backporting).
After we switch to the new image (and all the windows tests are green), we can incrementally move the builds that are still using VS2017 to VS2019.