Update all Debian:9 to Debian:10#31917
Conversation
f60439a to
3d8bebb
Compare
jtattermusch
left a comment
There was a problem hiding this comment.
LGTM with a comment.
| # Java required by Android SDK | ||
| RUN apt-get update && apt-get -y install openjdk-8-jdk && apt-get clean | ||
| # Java required by Android SDK (using Eclipse Temurin Package) | ||
| RUN apt install -y wget apt-transport-https && \ |
There was a problem hiding this comment.
never heard of "temurin-8-jdk", why can't you simply install openjdk?
Debian 10 has "openjdk-11-jdk" and I'd prefer to avoid anything non-standard, since it makes things more confusing and harder to maintain.
There was a problem hiding this comment.
That's a sort of next official java 8 sdk (https://blog.adoptopenjdk.net/2021/03/transition-to-eclipse-an-update/). I wanted to keep everything else other than Debian upgrade here but I can try Jdk 11 here to see whether it works with Android SDK.
There was a problem hiding this comment.
Oh it turned out that Android SDK this image uses does require Java 8 SDK. So this should be like this until we upgrade SDK.
|
I'm going to get this merged as Abseil upgrade needs this change. I'll revisit Android SDK issue later. |
This reverts commit 8ef7dcb.
Debian:9 (stretch) reached EOL on June 30, 2022 (ref) so all docker images based on Debian:9 switch to Debian:10.
This is prerequisite to #31916.