Revert "[CSHARP] Add base_namespace experimental option to C# plugin"#32957
Merged
Revert "[CSHARP] Add base_namespace experimental option to C# plugin"#32957
Conversation
apolcyn
approved these changes
Apr 27, 2023
Contributor
|
cc @tonydnewell FYI |
XuanWang-Amos
pushed a commit
to XuanWang-Amos/grpc
that referenced
this pull request
May 1, 2023
…grpc#32957) Reverts grpc#32636 ``` src/compiler/csharp_generator_helpers.h:25:7: error: no member named 'compiler' in namespace ... src/compiler/csharp_generator_helpers.h:25:25: error: no member named 'csharp' in namespace 'compiler' ... ```
paulosjca
pushed a commit
to paulosjca/grpc
that referenced
this pull request
May 4, 2023
…grpc#32957) Reverts grpc#32636 ``` src/compiler/csharp_generator_helpers.h:25:7: error: no member named 'compiler' in namespace ... src/compiler/csharp_generator_helpers.h:25:25: error: no member named 'csharp' in namespace 'compiler' ... ```
tonydnewell
added a commit
to tonydnewell/grpc
that referenced
this pull request
Jun 1, 2023
… plugin" (grpc#32957)" This reverts commit d63f8d4.
jtattermusch
pushed a commit
to jtattermusch/grpc
that referenced
this pull request
Jun 23, 2023
… plugin" (grpc#32957)" This reverts commit d63f8d4.
jtattermusch
pushed a commit
to jtattermusch/grpc
that referenced
this pull request
Jun 26, 2023
… plugin" (grpc#32957)" This reverts commit d63f8d4.
mario-vimal
pushed a commit
to mario-vimal/grpc
that referenced
this pull request
Jul 13, 2023
… patch) (grpc#33535) Reintroduces patched version of grpc#32636 (which was reverted in grpc#32957). Together with cl/542843305, the internal build should work fine. Supersedes grpc#33310 (since a patch is also needed). --------- Co-authored-by: tony <tony.newell@pobox.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #32636