Skip to content

[Python fix-it][Gevent] Enable gevent _dynamic_stubs_test#32842

Merged
XuanWang-Amos merged 3 commits intogrpc:masterfrom
XuanWang-Amos:fixit_enableGeventTest
Apr 12, 2023
Merged

[Python fix-it][Gevent] Enable gevent _dynamic_stubs_test#32842
XuanWang-Amos merged 3 commits intogrpc:masterfrom
XuanWang-Amos:fixit_enableGeventTest

Conversation

@XuanWang-Amos
Copy link
Copy Markdown
Contributor

@XuanWang-Amos XuanWang-Amos commented Apr 10, 2023

Re-enable this test since it's now passing after gevent reimplementation.

Fix: #15411

@XuanWang-Amos XuanWang-Amos changed the title Enable gevent _dynamic_stubs_test [Python fix-it][Gevent] Enable gevent _dynamic_stubs_test Apr 10, 2023
@XuanWang-Amos XuanWang-Amos added the release notes: no Indicates if PR should not be in release notes label Apr 10, 2023
Copy link
Copy Markdown
Contributor

@gnossen gnossen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@XuanWang-Amos XuanWang-Amos marked this pull request as ready for review April 11, 2023 23:58
@XuanWang-Amos XuanWang-Amos enabled auto-merge (squash) April 11, 2023 23:58
@XuanWang-Amos XuanWang-Amos merged commit 95c4df5 into grpc:master Apr 12, 2023
@XuanWang-Amos XuanWang-Amos deleted the fixit_enableGeventTest branch April 12, 2023 22:32
@copybara-service copybara-service bot added the imported Specifies if the PR has been imported to the internal repository label Apr 13, 2023
XuanWang-Amos added a commit to XuanWang-Amos/grpc that referenced this pull request May 1, 2023
Re-enable this test since it's now passing after gevent
reimplementation.

Fix: grpc#15411
wanlin31 pushed a commit that referenced this pull request May 18, 2023
Re-enable this test since it's now passing after gevent
reimplementation.

Fix: #15411
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bloat/none imported Specifies if the PR has been imported to the internal repository lang/Python per-call-memory/neutral per-channel-memory/neutral release notes: no Indicates if PR should not be in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-enable broken tests with gevent and unpin gevent on Windows

3 participants