[client channel] move health checking code out of subchannel and into LB policies#32709
Merged
markdroth merged 19 commits intoApr 20, 2023
Merged
Conversation
…nt_data_watcher_new
…nt_data_watcher_new
…nt_data_watcher_new
…nt_data_watcher_new
…nt_data_watcher_new
eugeneo
approved these changes
Apr 19, 2023
| void set_attempting_index(size_t index) { attempting_index_ = index; } | ||
|
|
||
| private: | ||
| std::shared_ptr<WorkSerializer> work_serializer() const override { |
Contributor
There was a problem hiding this comment.
Can this be moved to a base class?
Member
Author
There was a problem hiding this comment.
Unfortunately, it can't. The problem is that LoadBalancingPolicy::work_serializer() is protected, so it can be accessed only in subclasses. And the base SubchannelList class is not nested inside of a subclass of LoadBalancingPolicy, but the individual subclasses of SubchannelList are nested inside of subclasses of LoadBalancingPolicy, so this is where it needs to be.
I agree that this is ugly. However, I plan to clean this up as part of the changes I'm going to be making for the dualstack design. Once I make pick_first the universal leaf policy, it will be the only policy actually using SubchannelList, and at that point I will move the code directly into pick_first so that it no longer needs to be a separate base class.
XuanWang-Amos
pushed a commit
to XuanWang-Amos/grpc
that referenced
this pull request
May 1, 2023
… LB policies (grpc#32709) This paves the way for making pick_first the universal leaf policy (see grpc#32692), which will be needed for the dualstack design. That change will require changing pick_first to see both the raw connectivity state and the health-checking connectivity state of a subchannel, so that we can enable health checking when pick_first is used underneath round_robin without actually changing the pick_first connectivity logic (currently, pick_first always disables health checking). To make it possible to do that, this PR moves the health checking code out of the subchannel and into a separate API using the same data-watcher mechanism that was added for ORCA OOB calls.
wanlin31
pushed a commit
that referenced
this pull request
May 18, 2023
… LB policies (#32709) This paves the way for making pick_first the universal leaf policy (see #32692), which will be needed for the dualstack design. That change will require changing pick_first to see both the raw connectivity state and the health-checking connectivity state of a subchannel, so that we can enable health checking when pick_first is used underneath round_robin without actually changing the pick_first connectivity logic (currently, pick_first always disables health checking). To make it possible to do that, this PR moves the health checking code out of the subchannel and into a separate API using the same data-watcher mechanism that was added for ORCA OOB calls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This paves the way for making pick_first the universal leaf policy (see #32692), which will be needed for the dualstack design. That change will require changing pick_first to see both the raw connectivity state and the health-checking connectivity state of a subchannel, so that we can enable health checking when pick_first is used underneath round_robin without actually changing the pick_first connectivity logic (currently, pick_first always disables health checking). To make it possible to do that, this PR moves the health checking code out of the subchannel and into a separate API using the same data-watcher mechanism that was added for ORCA OOB calls.