[EventEngine] Add more granular trace flags#32376
Merged
drfloob merged 1 commit intogrpc:masterfrom Feb 14, 2023
Merged
Conversation
Member
|
Not for this PR, but to put it out there: |
Member
Author
I'd use it here for sure. I think there are other small (<= 3 sub-traces) potential uses with call, client_channel, subchannel. XDS also has quite a few, but I'm not sure how valuable it would be to enable the bulk of them at once. Regarding the change, the trace flags are sort of public API, right? Changing existing flags could upset some folks who rely on them already. If we did any flag restructuring, we may want to ensure the old flags are still supported. |
Contributor
|
Thanks for creating this AJ. LGTM |
Vignesh2208
approved these changes
Feb 14, 2023
drfloob
added a commit
that referenced
this pull request
Feb 15, 2023
A handful of problems were identified while writing the WindowsEventEngine Listener. To make the listener review easier, these fixes can be landed separately. This is built upon #32376 Problems that are fixed in this PR: * `OnConnectCompleted` held a Mutex while calling the user callback, which can deadlock. * The WinSocket and some associated data needs to remain alive after the Endpoint destroyed, since Windows IOCP still needs to use some of that data. Endpoint destruction and socket shutdown are now decoupled, with the socket managed by a shared_ptr. <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> --------- Co-authored-by: drfloob <drfloob@users.noreply.github.com>
XuanWang-Amos
pushed a commit
to XuanWang-Amos/grpc
that referenced
this pull request
May 1, 2023
The set of trace flags is now: * event_engine * event_engine_endpoint * event_engine_endpoint_data: additionally log all sent/received data, similar to what the shims do. * event_engine_poller <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. -->
XuanWang-Amos
pushed a commit
to XuanWang-Amos/grpc
that referenced
this pull request
May 1, 2023
A handful of problems were identified while writing the WindowsEventEngine Listener. To make the listener review easier, these fixes can be landed separately. This is built upon grpc#32376 Problems that are fixed in this PR: * `OnConnectCompleted` held a Mutex while calling the user callback, which can deadlock. * The WinSocket and some associated data needs to remain alive after the Endpoint destroyed, since Windows IOCP still needs to use some of that data. Endpoint destruction and socket shutdown are now decoupled, with the socket managed by a shared_ptr. <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> --------- Co-authored-by: drfloob <drfloob@users.noreply.github.com>
wanlin31
pushed a commit
that referenced
this pull request
May 18, 2023
The set of trace flags is now: * event_engine * event_engine_endpoint * event_engine_endpoint_data: additionally log all sent/received data, similar to what the shims do. * event_engine_poller <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. -->
wanlin31
pushed a commit
that referenced
this pull request
May 18, 2023
A handful of problems were identified while writing the WindowsEventEngine Listener. To make the listener review easier, these fixes can be landed separately. This is built upon #32376 Problems that are fixed in this PR: * `OnConnectCompleted` held a Mutex while calling the user callback, which can deadlock. * The WinSocket and some associated data needs to remain alive after the Endpoint destroyed, since Windows IOCP still needs to use some of that data. Endpoint destruction and socket shutdown are now decoupled, with the socket managed by a shared_ptr. <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> --------- Co-authored-by: drfloob <drfloob@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The set of trace flags is now: