[codegen] Escape variable delimiters in raw comment printing#32190
Merged
Conversation
0ebf859 to
33eb5f9
Compare
markdroth
approved these changes
Jan 24, 2023
| } | ||
|
|
||
| std::string EscapeVariableDelimiters(std::string&& mut_str) { | ||
| size_t index = 0; |
Member
There was a problem hiding this comment.
Consider instead using absl::StrReplaceAll() for this.
Member
Author
There was a problem hiding this comment.
That was my first instinct, but the grpc_plugin_support target has very few dependencies, and I'm not entirely sure why, it seems almost by design. Maybe for code bloat reasons? Anyhow, that's the only reason I didn't use abseil here.
Contributor
There was a problem hiding this comment.
I feel like we should be careful on adding more dependency to grpc_plugin_support.
veblush
approved these changes
Jan 24, 2023
veblush
left a comment
Contributor
There was a problem hiding this comment.
Thank you for having this quick fix.
This was referenced Feb 16, 2023
XuanWang-Amos
pushed a commit
to XuanWang-Amos/grpc
that referenced
this pull request
May 1, 2023
wanlin31
pushed a commit
that referenced
this pull request
May 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #32171