xDS interop: Handle the edge case when rand deployment_id is all nums#30901
Merged
sergiitk merged 1 commit intogrpc:masterfrom Sep 8, 2022
Merged
xDS interop: Handle the edge case when rand deployment_id is all nums#30901sergiitk merged 1 commit intogrpc:masterfrom
sergiitk merged 1 commit intogrpc:masterfrom
Conversation
Fun edge case: when `rand_string()` happen to generate numbers only, yaml interprets `deployment_id` label value as an integer, but k8s expects label values to be strings. K8s responds with a barely readable 400 Bad Request error: `ReadString: expects \" or n, but found 9, error found in #10 byte of ...|ent_id`. Prepending deployment name forces deployment_id into a string, as well as it's just a better description.
gnossen
approved these changes
Sep 8, 2022
sergiitk
added a commit
to sergiitk/grpc
that referenced
this pull request
Dec 8, 2023
…grpc#30901) Fun edge case: when `rand_string()` happen to generate numbers only, yaml interprets `deployment_id` label value as an integer, but k8s expects label values to be strings. K8s responds with a barely readable 400 Bad Request error: `ReadString: expects \" or n, but found 9, error found in #10 byte of ...|ent_id`. Prepending deployment name forces deployment_id into a string, as well as it's just a better description.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fun edge case: when
rand_string()happen to generate numbers only, yaml interpretsdeployment_idlabel value as an integer, but k8s expects label values to be strings.K8s responds with a barely readable 400 Bad Request error:
ReadString: expects \" or n, but found 9, error found in #10 byte of ...|ent_id.Prepending deployment name forces
deployment_idinto a string, as well as it's just a better description.ref b/245709149
cc @zasweq