Properly selecting chunks of code for the wakeup fd codepath.#306
Merged
dklempner merged 4 commits intogrpc:masterfrom Feb 2, 2015
nicolasnoble:wakeup-fd-fix
Merged
Properly selecting chunks of code for the wakeup fd codepath.#306dklempner merged 4 commits intogrpc:masterfrom nicolasnoble:wakeup-fd-fix
dklempner merged 4 commits intogrpc:masterfrom
nicolasnoble:wakeup-fd-fix
Conversation
Contributor
Author
|
Also, mentioning @dklempner for double-checking what I am doing here. |
Also fix log_posix to get things compiling.
Member
|
I sent you a pull request with what I'm thinking. |
Make _posix usage match 'the rules'
Contributor
Author
|
Done :-) |
src/core/iomgr/wakeup_fd_posix.h
Outdated
Contributor
There was a problem hiding this comment.
We should either nuke or move this comment.
dklempner
added a commit
that referenced
this pull request
Feb 2, 2015
Properly selecting chunks of code for the wakeup fd codepath.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.