Remove Python2 from python_configure.bzl#28406
Merged
lidizheng merged 3 commits intogrpc:masterfrom Dec 28, 2021
Merged
Conversation
Contributor
Author
|
Known failure: Distribution Tests Python Linux: #28405 |
gnossen
approved these changes
Dec 26, 2021
Contributor
gnossen
left a comment
There was a problem hiding this comment.
LGTM. Thanks for taking care of this!
antoninbas
added a commit
to p4lang/p4runtime
that referenced
this pull request
Jan 24, 2022
To include this fix: grpc/grpc#28406 We can upgrade to v1.44.0 when it is released.
antoninbas
added a commit
to p4lang/p4runtime
that referenced
this pull request
Jan 24, 2022
* Update versions of dependencies for Bazel build Our CI uses the latest available version of Bazel, which is now 5.0. With this new Bazel release, the build started breaking, which required upgrading dependencies to the following versions: * Protobuf: v3.18.1 * gRPC: v1.43.0 * googleapis: top-of-tree * rules_proto: top-of-tree * rules_go: v0.29.0 * Use gRPC v1.44.0-pre1 To include this fix: grpc/grpc#28406 We can upgrade to v1.44.0 when it is released.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As title.
Fixes #28026. Richard helped to offer some background about this issue. After discussion, we want to try remove the Python2-header-finding logic from our Bazel build.
This should unblock #28392.