Fix grpc_java* Docker images#281
Merged
donnadionne merged 1 commit intogrpc:masterfrom Jan 29, 2015
ejona86:docker
Merged
Conversation
The images seem to have been broken starting with 12e12a3, but the removal of Maven support from grpc-java also broke them further. SSH handling no longer uses $HOME as it does not agree with /etc/passwd in older docker versions[1] and prevented SSH from seeing the config file. Some effort was also made to reduce the image sizes by removing temporary files. 1. moby/moby#2968
donnadionne
added a commit
that referenced
this pull request
Jan 29, 2015
Fix grpc_java* Docker images
Member
Author
|
For posterity, the removal of Maven was grpc/grpc-java@1905249 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The images seem to have been broken starting with 12e12a3, but the
removal of Maven support from grpc-java also broke them further.
SSH handling no longer uses $HOME as it does not agree with /etc/passwd
in older docker versions[1] and prevented SSH from seeing the config
file.
Some effort was also made to reduce the image sizes by removing
temporary files.