Add bazel distribtests (minimalist version that only tests with bazel 3.x and 4.x)#27486
Merged
jtattermusch merged 14 commits intogrpc:masterfrom Sep 28, 2021
Merged
Add bazel distribtests (minimalist version that only tests with bazel 3.x and 4.x)#27486jtattermusch merged 14 commits intogrpc:masterfrom
jtattermusch merged 14 commits intogrpc:masterfrom
Conversation
Contributor
|
Looks like Windows RBE is passing. That was the main blocker on the PR I originally wrote. Absolutely LGTM. I'll follow up with some advanced test cases (i.e. usage of |
gnossen
approved these changes
Sep 27, 2021
Contributor
Author
javiyt
pushed a commit
to javiyt/grpc
that referenced
this pull request
Sep 28, 2021
… 3.x and 4.x) (grpc#27486) (#1) * Make repo globally buildable * Add initial distrib test script * Add test script * Support multiple versions * Split out a separate latest version test * Integrate with kokoro * make tools/bazel version overridable * added simplified test_single_bazel_version.sh * cleanup .bazelignore * only test 3.x and 4.x * always test all the bazel versions * revert unnecessary changes * revert unnecessary changes * fix shellcheck error Co-authored-by: Richard Belleville <rbellevi@google.com> Co-authored-by: Jan Tattermusch <jtattermusch@users.noreply.github.com> Co-authored-by: Richard Belleville <rbellevi@google.com>
javiyt
pushed a commit
to javiyt/grpc
that referenced
this pull request
Sep 28, 2021
… 3.x and 4.x) (grpc#27486) (#2) * Make repo globally buildable * Add initial distrib test script * Add test script * Support multiple versions * Split out a separate latest version test * Integrate with kokoro * make tools/bazel version overridable * added simplified test_single_bazel_version.sh * cleanup .bazelignore * only test 3.x and 4.x * always test all the bazel versions * revert unnecessary changes * revert unnecessary changes * fix shellcheck error Co-authored-by: Richard Belleville <rbellevi@google.com> Co-authored-by: Jan Tattermusch <jtattermusch@users.noreply.github.com> Co-authored-by: Richard Belleville <rbellevi@google.com>
paulosjca
pushed a commit
to paulosjca/grpc
that referenced
this pull request
Sep 29, 2021
… 3.x and 4.x) (grpc#27486) * Make repo globally buildable * Add initial distrib test script * Add test script * Support multiple versions * Split out a separate latest version test * Integrate with kokoro * make tools/bazel version overridable * added simplified test_single_bazel_version.sh * cleanup .bazelignore * only test 3.x and 4.x * always test all the bazel versions * revert unnecessary changes * revert unnecessary changes * fix shellcheck error Co-authored-by: Richard Belleville <rbellevi@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a minimalist version of distribtests from #25318 (and yes, most logic comes from there)