Migrate the last of the Python code from Google-internal source control to git.#274
Migrate the last of the Python code from Google-internal source control to git.#274ctiller merged 2 commits intogrpc:masterfrom nathanielmanistaatgoogle:python-introduction
Conversation
|
Also please take a look @soltanmm. |
|
start_invoke transition LGTM |
|
Where should I look for the port selection logic? |
|
I don't really have any concern with this PR. |
|
@ctiller port selection logic is exposed via the (Python) server's add_http2_addr method and the Fore's start method. @craigcitro Please also take a look and merge if satisfied? |
src/python/src/_adapter/_c_test.py
Outdated
There was a problem hiding this comment.
'[::]:0' (and in the other places)
... make it ipv4&6 compatible
There was a problem hiding this comment.
Done; thanks for pointing these out.
|
(All outstanding comments addressed.) |
src/python/setup.py
Outdated
There was a problem hiding this comment.
actually, shouldn't it stay in the project root dir for installation purposes? (this is the usual way setup.py works in my experience ...)
There was a problem hiding this comment.
It's tough in a multi-language repository. For the scope of this commit: no, it needn't. Outside of this commit: maybe? I have a feeling that it won't move back to the repository root - see the way that for testing the Python code is currently installed into the virtual environment with "python2.7_virtual_environment/bin/pip install src/python".
I've removed the out-of-date TODO.
|
one comment on a TODO, otherwise LGTM. (i can't merge the PR, since i don't have write access to the repo.) |
The source code is moved from src/python to src/python/src. A setup.py is added at src/python. The build_python.sh and run_python.sh scripts are updated to build and run the Python tests by building a package and installing it in the developer's Python 2.7 virtual environment.
|
Ping to those reviewers with permissions to merge this - I believe all outstanding comments have been addressed. Also I used the process outlined at http://stackoverflow.com/questions/1186535/how-to-modify-a-specified-commit to remove the TODO in setup.py as it never actually applies at any stage of the history of this branch. |
…tion Migrate the last of the Python code from Google-internal source control to git.
Please review @nicolasnoble @murgatroid99 @tbetbetbe @ctiller. Changes made include:
(1) Path migrations.
(2) Migration from grpc_call_start_invoke to grpc_call_invoke.
(3) Port auto-selection in tests.