Make grpc lib compile on mac by adding in header files currently used for posix,#270
Closed
vjpai wants to merge 1 commit intogrpc:masterfrom
vjpai:master
Closed
Make grpc lib compile on mac by adding in header files currently used for posix,#270vjpai wants to merge 1 commit intogrpc:masterfrom vjpai:master
vjpai wants to merge 1 commit intogrpc:masterfrom
vjpai:master
Conversation
… posix, as opposed to non-existent header file.
Contributor
Author
|
But I hope that this doesn't screw up the Windows build. Need to investigate. |
Member
|
I sent you a pull request against this one with something I think is marginally better. |
Contributor
|
I don't believe that's what we want to do here. --edit-- I guess Craig beat me to it. |
Contributor
Author
|
Craig, I'm not seeing the marginally better pull request, can you tell me where it is? |
Contributor
|
Check vjpai#1 |
Contributor
|
So I am superseding this PR with #306. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as opposed to non-existent header file. Some tests still do not compile as they need updated include for protobufs.