Change Node metadata representation to a more reasonable one#268
Merged
tbetbetbe merged 1 commit intogrpc:masterfrom Jan 29, 2015
murgatroid99:node_metadata_representation
Merged
Change Node metadata representation to a more reasonable one#268tbetbetbe merged 1 commit intogrpc:masterfrom murgatroid99:node_metadata_representation
tbetbetbe merged 1 commit intogrpc:masterfrom
murgatroid99:node_metadata_representation
Conversation
tbetbetbe
added a commit
that referenced
this pull request
Jan 29, 2015
Change Node metadata representation to a more reasonable one
lalo
added a commit
to lalo/grpc
that referenced
this pull request
Oct 19, 2017
- Add BUILD_ONLY as an argument to add_bond_test() CMake function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node metadata is now represented as objects that map key strings to arrays of value buffers (because metadata values can have arbitrary binary data). For simplicity,
call.addMetadataalso accepts string values in place of buffer values. This closes #264