Add service account credential#266
Merged
chen-wang merged 3 commits intogrpc:masterfrom Jan 29, 2015
chen-wang:master
Merged
Conversation
examples/tips/client_main.cc
Outdated
Contributor
There was a problem hiding this comment.
You do not need this. In the test, we pass in this only to verify the returned value is correct.
chen-wang
added a commit
that referenced
this pull request
Jan 29, 2015
Add service account credential
Contributor
|
I think the procedure is to let me do the push. But LGTM On Wed, Jan 28, 2015 at 5:56 PM, Chen Wang notifications@github.com wrote:
|
Member
|
The procedure is to let the reviewer do the push. Please please don't merge your own pull requests. |
Contributor
|
That's the second time already. Please stop. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.