Upgrade bazel toolchain to 3.7.1 (and upgrade bazel to 3.7.1) by jtattermusch · Pull Request #25001 · grpc/grpc

jtattermusch · 2020-12-15T17:10:22Z

Based on #25000, but also upgrade the bazel toolchain.

…exec_properties_dict

jtattermusch · 2020-12-15T17:14:36Z

WORKSPACE

-            {
-                "label:os": "ubuntu",
-                "label:machine_size": "large",
+        "LARGE_MACHINE": create_rbe_exec_properties_dict(


@gnossen depending on what the bazel distribtests say, we might want to reintroduce parts of the workaround that was used previously (conditionally based on the bazel version used?).
It would be good to get some data on what bazel versions we can continue to support.

jtattermusch · 2020-12-15T19:10:23Z

Ubsan tests seem to be failing https://source.cloud.google.com/results/invocations/598d1d3e-58be-4edb-a263-c4d01a2f6a70/log which is something that needs to be investigated.

jtattermusch · 2020-12-15T20:16:47Z

Ubsan tests seem to be failing https://source.cloud.google.com/results/invocations/598d1d3e-58be-4edb-a263-c4d01a2f6a70/log which is something that needs to be investigated.

It looks like some UBSAN toolchain setup problem:

ERROR: /tmpfs/tmp/bazel/external/io_opencensus_cpp/opencensus/stats/BUILD:57:11: Couldn't build file external/io_opencensus_cpp/opencensus/stats/_objs/core/distribution.pic.o: undeclared inclusion(s) in rule '@io_opencensus_cpp//opencensus/stats:core':
this rule is missing dependency declarations for the following files included by 'io_opencensus_cpp/opencensus/stats/internal/distribution.cc':
  '/usr/local/lib/clang/11.0.0/include/stdint.h'
  '/usr/local/lib/clang/11.0.0/include/stdarg.h'
  '/usr/local/lib/clang/11.0.0/include/stddef.h'
...

jtattermusch · 2020-12-15T20:51:33Z

Ubsan tests seem to be failing https://source.cloud.google.com/results/invocations/598d1d3e-58be-4edb-a263-c4d01a2f6a70/log which is something that needs to be investigated.

It looks like some UBSAN toolchain setup problem:

ERROR: /tmpfs/tmp/bazel/external/io_opencensus_cpp/opencensus/stats/BUILD:57:11: Couldn't build file external/io_opencensus_cpp/opencensus/stats/_objs/core/distribution.pic.o: undeclared inclusion(s) in rule '@io_opencensus_cpp//opencensus/stats:core':
this rule is missing dependency declarations for the following files included by 'io_opencensus_cpp/opencensus/stats/internal/distribution.cc':
  '/usr/local/lib/clang/11.0.0/include/stdint.h'
  '/usr/local/lib/clang/11.0.0/include/stdarg.h'
  '/usr/local/lib/clang/11.0.0/include/stddef.h'
...

Looks like this line needs to be updated, but I haven't found what to replace it with so that things work:

grpc/tools/remote_build/rbe_common.bazelrc

Line 94 in 5492cb6

    
           build:ubsan --crosstool_top=@bazel_toolchains//configs/experimental/ubuntu16_04_clang/1.3/bazel_0.29.1/ubsan:toolchain

stale · 2021-03-19T23:20:14Z

This issue/PR has been automatically marked as stale because it has not had any update (including commits, comments, labels, milestones, etc) for 30 days. It will be closed automatically if no further update occurs in 7 day. Thank you for your contributions!

jtattermusch · 2021-09-22T10:38:53Z

Ubsan tests seem to be failing https://source.cloud.google.com/results/invocations/598d1d3e-58be-4edb-a263-c4d01a2f6a70/log which is something that needs to be investigated.

It looks like some UBSAN toolchain setup problem:
ERROR: /tmpfs/tmp/bazel/external/io_opencensus_cpp/opencensus/stats/BUILD:57:11: Couldn't build file external/io_opencensus_cpp/opencensus/stats/_objs/core/distribution.pic.o: undeclared inclusion(s) in rule '@io_opencensus_cpp//opencensus/stats:core':
this rule is missing dependency declarations for the following files included by 'io_opencensus_cpp/opencensus/stats/internal/distribution.cc':
  '/usr/local/lib/clang/11.0.0/include/stdint.h'
  '/usr/local/lib/clang/11.0.0/include/stdarg.h'
  '/usr/local/lib/clang/11.0.0/include/stddef.h'
...
Looks like this line needs to be updated, but I haven't found what to replace it with so that things work:

grpc/tools/remote_build/rbe_common.bazelrc

Line 94 in 5492cb6

build:ubsan --crosstool_top=@bazel_toolchains//configs/experimental/ubuntu16_04_clang/1.3/bazel_0.29.1/ubsan:toolchain

It looks like simply removing the line at

grpc/tools/remote_build/rbe_common.bazelrc

Line 94 in 5492cb6

    
           build:ubsan --crosstool_top=@bazel_toolchains//configs/experimental/ubuntu16_04_clang/1.3/bazel_0.29.1/ubsan:toolchain

fixes the ubsan build.

FTR There are some new UBSAN errors with that approach, but they could be legitimate (and caused e.g. by updating to a newer version of clang 10 -> 11).
https://source.cloud.google.com/results/invocations/27ee65c9-fc80-46ec-90f1-faf169ff01ff/targets/%2F%2Ftest%2Fcore%2Fend2end:h2_tls_test@stream_compression_ping_pong_streaming@poller%3Dpoll/log

jtattermusch · 2021-09-22T12:00:50Z

superseded by #27410

jtattermusch added 5 commits December 15, 2020 17:29

update bazel version in other places too

bf21b2b

add bazel 3.7.1 to update_mirror.sh

619042a

regenerate dockerfiles

caddd2f

upgrade bazel toolchain to 3.7.1

cb81b2d

use create_rbe_exec_properties_dict instead of the deprecated create_…

21c35e6

…exec_properties_dict

jtattermusch requested review from apolcyn, gnossen, nicolasnoble and veblush as code owners December 15, 2020 17:10

jtattermusch assigned gnossen and lidizheng Dec 15, 2020

jtattermusch added release notes: yes Indicates if PR needs to be in release notes lang/c++ labels Dec 15, 2020

jtattermusch commented Dec 15, 2020

View reviewed changes

gnossen approved these changes Dec 15, 2020

View reviewed changes

jtattermusch mentioned this pull request Dec 15, 2020

Upgrade bazel toolchain #23087

Closed

jtattermusch mentioned this pull request Feb 1, 2021

Bazel distribtests #25318

Open

stale bot added the disposition/stale label Mar 19, 2021

jtattermusch added the disposition/never stale label Mar 22, 2021

stale bot removed the disposition/stale label Mar 22, 2021

jtattermusch mentioned this pull request Jun 16, 2021

Update rules_apple and apple_support #26438

Closed

jtattermusch mentioned this pull request Sep 22, 2021

Reenable UBSAN #27428

Closed

RBE ubsan doesnt require the crosstool_top hack anymore

064bf34

jtattermusch requested a review from ctiller as a code owner September 22, 2021 10:47

jtattermusch mentioned this pull request Sep 22, 2021

Upgrade bazel to 4.2.1 (LTS), upgrade bazel toolchain to 4.1.0 #27410

Merged

jtattermusch closed this Sep 22, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade bazel toolchain to 3.7.1 (and upgrade bazel to 3.7.1)#25001

Upgrade bazel toolchain to 3.7.1 (and upgrade bazel to 3.7.1)#25001
jtattermusch wants to merge 6 commits intogrpc:masterfrom
jtattermusch:upgrade_bazel_371_toolchain

jtattermusch commented Dec 15, 2020

Uh oh!

jtattermusch Dec 15, 2020

Uh oh!

jtattermusch commented Dec 15, 2020

Uh oh!

jtattermusch commented Dec 15, 2020 •

edited

Loading

Uh oh!

jtattermusch commented Dec 15, 2020

Uh oh!

stale bot commented Mar 19, 2021

Uh oh!

jtattermusch commented Sep 22, 2021

Uh oh!

jtattermusch commented Sep 22, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

jtattermusch commented Dec 15, 2020

Uh oh!

jtattermusch Dec 15, 2020

Choose a reason for hiding this comment

Uh oh!

jtattermusch commented Dec 15, 2020

Uh oh!

jtattermusch commented Dec 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jtattermusch commented Dec 15, 2020

Uh oh!

stale bot commented Mar 19, 2021

Uh oh!

jtattermusch commented Sep 22, 2021

Uh oh!

jtattermusch commented Sep 22, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jtattermusch commented Dec 15, 2020 •

edited

Loading