Upgrade bazel to 3.7.1 (repository-wide)#25000
Merged
jtattermusch merged 3 commits intogrpc:masterfrom Dec 15, 2020
Merged
Conversation
lidizheng
approved these changes
Dec 15, 2020
Contributor
|
@jtattermusch Shouldn't CI have failed as a result of these values going out of sync? |
gnossen
approved these changes
Dec 15, 2020
Contributor
|
Both 2.2.0 and 3.7.1 compile fine with gRPC hid the problem. E.g., the Sanity test still uses 2.2.0. In other tests, Bazel was reinstalled. |
Contributor
Author
We don't have a sanity test in place for these (which seems to be an opportunity for improvement). |
Contributor
Author
|
The android failure is unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as #24981, but this time done properly.