You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR upgraded our Bazel version from 2.2.0 to 3.7.1. This is needed to upgrade upb to the latest version, which includes converting messages into JSON. Newer Bazel broke two features for upb (bazelbuild/bazel#11584 and bazelbuild/bazel#8118), and made upb incompatible with Bazel 2.x.
So far, the tests are looking good, and none of the new backward incompatibilities affect gRPC.
I was blocked by bazel test .... It couldn't build. Just found out this morning, that the ... works surprisingly as it picks up tests in third_party folder, and those tests assumed different folder structure.
In future, we could have a new target for "all gRPC tests", or somehow exlucde the third_party directory from ....
@lidizheng I think adding a .bazelignore at the project root with third_party/ in it should fix the bazel build ... problem. There are a couple of files in third_party/ that we belong to our codebase, but they're .bzl files, not BUILD files, so the file may need to list individual third_party/foo_project/ directories instead.
We already have a .bazelignore file so you can add any non-grpc projects to it if they cause problems. As Richards said, we can't simply add third_party there because some belong to gRPC.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jtattermusch
left a comment
This PR upgraded our Bazel version from 2.2.0 to 3.7.1. This is needed to upgrade upb to the latest version, which includes converting messages into JSON. Newer Bazel broke two features for upb (bazelbuild/bazel#11584 and bazelbuild/bazel#8118), and made upb incompatible with Bazel 2.x.
So far, the tests are looking good, and none of the new backward incompatibilities affect gRPC.
I was blocked by
bazel test .... It couldn't build. Just found out this morning, that the...works surprisingly as it picks up tests in third_party folder, and those tests assumed different folder structure.In future, we could have a new target for "all gRPC tests", or somehow exlucde the third_party directory from
....CC @jtattermusch