Skip to content

Remove highland as a dependency of the Node library#234

Merged
tbetbetbe merged 4 commits intogrpc:masterfrom
murgatroid99:node_remove_highland
Jan 27, 2015
Merged

Remove highland as a dependency of the Node library#234
tbetbetbe merged 4 commits intogrpc:masterfrom
murgatroid99:node_remove_highland

Conversation

@murgatroid99
Copy link
Copy Markdown
Member

This closes #214

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this correct? It does not appear to do anything. Perhaps explain why in the comments?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was a mistake. I pushed a fix.

tbetbetbe added a commit that referenced this pull request Jan 27, 2015
Remove highland as a dependency of the Node library
@tbetbetbe tbetbetbe merged commit c5e9018 into grpc:master Jan 27, 2015
@murgatroid99 murgatroid99 deleted the node_remove_highland branch January 28, 2015 18:58
stanley-cheung pushed a commit to stanley-cheung/grpc that referenced this pull request Aug 27, 2015
Upgrade C# example to use the latest nuget packages
@lock lock bot locked as resolved and limited conversation to collaborators Feb 2, 2019
@lock lock bot unassigned tbetbetbe Feb 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove highland from Node dev dependencies

2 participants