Fixed Node tests hanging at the end again#224
Merged
tbetbetbe merged 2 commits intogrpc:masterfrom Jan 27, 2015
murgatroid99:node_fix_test_hang2
Merged
Fixed Node tests hanging at the end again#224tbetbetbe merged 2 commits intogrpc:masterfrom murgatroid99:node_fix_test_hang2
tbetbetbe merged 2 commits intogrpc:masterfrom
murgatroid99:node_fix_test_hang2
Conversation
tbetbetbe
added a commit
that referenced
this pull request
Jan 27, 2015
Fixed Node tests hanging at the end again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor tests to separate startup and shutdown from test success. This closes #144.